Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates an adapter Tornado -> React\LoopInterface #12

Open
b-viguier opened this issue Sep 17, 2018 · 2 comments
Open

Creates an adapter Tornado -> React\LoopInterface #12

b-viguier opened this issue Sep 17, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@b-viguier
Copy link
Contributor

See React\LoopInterface.
Will improve interoperability possibilities.
May require some new features, like promise cancellation, or signal handling.
@b-viguier b-viguier added the enhancement New feature or request label Sep 17, 2018
@b-viguier b-viguier mentioned this issue Oct 16, 2018
Open
@kelunik
Copy link

kelunik commented Sep 7, 2019

Promise cancellation isn't required for a loop adapter, as promises and the event loop are entirely separated in ReactPHP.

@b-viguier
Copy link
Contributor Author

@kelunik You're absolutely right 😄
By design, Tornado doesn't separate these 2 concepts, maybe it confused me a bit while writing this… Or maybe it was to manager cancelTimer in a unified way in Tornado 🤔
Anyway, we need to cancellable promises for an edge case in promiseRace: we want to keep the first settled promise and cancel others… It's in the TODO list 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kelunik @b-viguier