Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom rewards for advancements #21

Open
SeptyIsHere opened this issue Apr 22, 2021 · 5 comments
Open

Custom rewards for advancements #21

SeptyIsHere opened this issue Apr 22, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@SeptyIsHere
Copy link

SeptyIsHere commented Apr 22, 2021

Description

Is your feature request related to a problem?

No, isn't related to a problem, my feature request is:
Advancements Customrewards, example:
You completed the advancement with crafting a diamond armor, you get an animal spawned on your box (or an item of the owner's choise)

Describe the solution you'd like us to implement.

Advancementsrewards.yml here you'll find every advancement that's enabled.

Describe alternatives you've considered.

I can't

Additional context

Like the real CaptiveMinecraft (box)

@BONNe
Copy link
Member

BONNe commented Apr 22, 2021

(the idea is to create a separate addon that does it, but currently noone has a time for that)

@BONNe
Copy link
Member

BONNe commented Apr 22, 2021

No, implementing it into the main plugin would mean that BentoBox core has a function that is not necessary for everyone. The idea of the BentoBox is to keep plugin with only main functions to run a gamemode, while addons allow enhancing each server.

If 'by plugin' you mean boxed gamemode, then it would not allow using the same advancement rewards in other GameModes without duplicating the code. Why SkyBlock should not be able to receive awards for advancements, or caveblock... or skygrid?

@SeptyIsHere
Copy link
Author

Alright.

@tastybento
Copy link
Member

I have been thinking of adding a rewards option to the advancements.yml file. Also, the idea is that what I learn from Boxed I plan to put into an addon for other game modes.

@tastybento tastybento added the enhancement New feature or request label Apr 22, 2021
@Fredthedoggy
Copy link

This is more of a data pack function, as you can already add functions and commands to execute on advancement complete.
I understand adding it here for simplicity, but it is already possible.

@tastybento tastybento changed the title Suggestion 1 Custom rewards for advancements Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants