Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto hide challenges #198

Open
sami3737 opened this issue Oct 23, 2019 · 3 comments
Open

Auto hide challenges #198

sami3737 opened this issue Oct 23, 2019 · 3 comments
Labels
Status: Under investigation Investigating the interest and the feasability of the issue. Type: Enhancement Improvement or modification which is usually a new feature.

Comments

@sami3737
Copy link

Hello,
Is it possible to add a new option to Challenges to enable/disable auto hide/show a challenges if a player don't have the required permissions from requiredPermissions challenge option.

Exemple:
{ "uniqueId": "BSkyBlock_treefarmHard", "friendlyName": "Tree farm Hard", "deployed": true, "description": [ "Create a simple tree farm" ], "icon": "is:\n ==: org.bukkit.inventory.ItemStack\n v: 1631\n type: SPRUCE_SAPLING\n", "order": 2, "challengeType": "ISLAND", "environment": [], "removeWhenCompleted": true, "level": "BSkyBlock_novice", "requirements": { "class": "IslandRequirements", "parameters": { "requiredBlocks": { "SPRUCE_SAPLING": 10 }, "removeBlocks": false, "requiredEntities": {}, "removeEntities": false, "searchRadius": 20, "requiredPermissions": [] } }, "requiredPermissions": ["test"], "requiredBlocks": {}, "removeBlocks": false, "requiredEntities": {}, "removeEntities": false, "requiredItems": [], "takeItems": true, "requiredExperience": 0, "takeExperience": false, "requiredMoney": 0, "takeMoney": false, "requiredIslandLevel": 0, "searchRadius": 10, "rewardText": "Extra dirt will always be handy", "rewardItems": [ "is:\n ==: org.bukkit.inventory.ItemStack\n v: 1631\n type: DIRT\n amount: 10\n" ], "rewardExperience": 50, "rewardMoney": 0, "rewardCommands": [], "repeatable": false, "repeatRewardText": "", "maxTimes": 0, "repeatExperienceReward": 0, "repeatItemReward": [], "repeatMoneyReward": 0, "repeatRewardCommands": [] }
By setting requiredPermissions to "test" i want to only display the challenges to the player that get the test permission either it will be hide if Auto Hide option is enabled.

In this way i need to be able to seperate every challenges to different Island diffculty/style.

@tastybento
Copy link
Member

@BONNe Is there already filtering on requiredPermissions?

@BONNe
Copy link
Member

BONNe commented Oct 30, 2019

Oh, my answer is missing...
yea... it is not hard to implement hiding option if permission is not matching... however, the reason why I haven't added it is because players without permission will not be able to complete a level where the challenge is placed. And they will not see that this challenge exists. They will all time sit with undone challenges.
Currently, there is no way how to do it, and requires a bit of redesign, as each game mode now can have only one set of levels and challenges. This will require multiple of them.
I have plans to implement this (as other addons have something similar).

@tastybento
Copy link
Member

Perhaps it could be an option that is used only for Free challenges?

@BONNe BONNe added Status: Under investigation Investigating the interest and the feasability of the issue. Type: Enhancement Improvement or modification which is usually a new feature. labels Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Under investigation Investigating the interest and the feasability of the issue. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
Development

No branches or pull requests

3 participants