Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the normal potion instead of a blank potion when using the 'Ignore meta-data' option #320

Open
2 tasks done
SenorFlamingo opened this issue Jun 20, 2023 · 0 comments
Open
2 tasks done
Labels
Type: Enhancement Improvement or modification which is usually a new feature.

Comments

@SenorFlamingo
Copy link

SenorFlamingo commented Jun 20, 2023

Is your feature request related to a problem?

Currently if you ignore the meta-data on a potion like a splash potion of weakness, you are left with a blank potion, which makes a challenge with potions completable with any kind of potion. If you don't ignore meta-data on potions, there could be an issue with compability with other plugins, such as tags applied to potions, making the challenge not completable in some cases.

Screenshot 2023-06-20 170145
Screenshot 2023-06-20 160127
Screenshot 2023-06-20 160115

Describe the solution you'd like.

I think the best solution would be so the plugin can detect the NBT tags for vanilla potions, and make 'Ignore meta-data' detect whether the potion has the specific NBT-tag that makes it the potion you've put into the challenge. That way, it will for example still detect a Splash potion of Weakness with any custom tags applied from other plugins as a Splash potion of Weakness, including randomized tags.

Describe alternatives you've considered.

I've tried readding the potion to the challenges as I thought it had something to do with the 1.19.4 update with the glow remove of the potions, but it seems to be an update to another plugin on the server has caused this problem. I've also contacted support with them that this is happening with their plugin, because usually this doesn't happen. It think it could be good for compatibility still if other plugins alter tags from potions, especially if something like a randomized effect or altered duration is applied to them.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.

Other

No response

@tastybento tastybento added the Type: Enhancement Improvement or modification which is usually a new feature. label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Projects
Development

No branches or pull requests

2 participants