feat: login and logout #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
한번에 너무 큰 수정이 올라온거 같은데 나눠서 올려주실수 있을까요? |
|
생각해보니 login 을 native 에서 진행하면 passport 가 필요 없을수도 있을것 같아요 |
joonamin
reviewed
Nov 18, 2024
| // TODO: add verify user middleware | ||
| router.post('/', async (req: Request, res: Response) => { | ||
| export const createEnquiry = async (req: Request, res: Response) => { |
| import { findUserById } from '@/services/v1/user' | ||
|
|
||
| export default function configurePassport(passport: PassportStatic): void { | ||
| passport.serializeUser((user: User, done) => { |
There was a problem hiding this comment.
세션을 로그인 과정에서 어떻게 이용하시나요?
oauth 로그인 이후에, jwt 를 기준으로 저희만의 jwt로 sign 해서 클라이언트에게 전달하는 로직으로 확인해서요..!
| } | ||
|
|
||
| export const logout = (req: Request, res: Response) => { | ||
| req.logout() |
There was a problem hiding this comment.
의도하신 로그아웃 기능이 사용자 정보를 저장한 세션을 만료시키는 것이 맞을까요?
|
@rlooo 해당 PR은 close 처리해주실 수 있으신가요? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.