OZ Submodule

[ponderingdemocritus]

Was a discussion about this.

Do we think this is the best path forward? IMO, I think it is for now as we will try to reuse as much of the OZ implementations as possible.

Perhaps we have a:

openzepplin submodule -> base OZ repo
realms_openzepplin -> imports OZ utils into custom implementations

Thoughts?

[milancermak]

Sounds about right. The only part I don't like is using git submodules. I'd prefer just a plain and simple copy-paste of the OZ contracts into our repo. That way, the repo would be properly set up with just a simple checkout (no need for submodule init help with CI and other tools as well) and we will all be sure we're working on the same codebase. Also, in case we would need a global change in the OZ contracts code, we could easily do it.

[rvorias]

fair enough

[lordabrax]

I agree with @milancermak that submodules is too bulky and should be avoided. How about writing a simple script that just update openzeppelin folder from OZ git and then try to compile all contracts to show where the potential problems might be?

[micksabox]

You can now install the library using pip install openzeppelin-cairo-contracts.