Adding artifacts to .gitignore #88
threepwave
started this conversation in
General
Replies: 2 comments 2 replies
-
Here's an example from loaf's mega-commit: |
Beta Was this translation helpful? Give feedback.
0 replies
-
This makes sense. Ultimately these are just relics from compiling, so we will always have conflicts when merging. I will introduce this in the current PR. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Edit: This has been Resolved! Artifacts are now ignored.
I believe artifacts are updated upon each
nile compile
. I find that often times I end up with new artifacts despite not making any changes to files.This mean small changes which modify 1-2 files can lead to 15-20 file commits by modifying a bunch of artifact .json files. I think this is distracting and will lead to use making mistakes. We'll miss files we accidentally included when committing because there are so many to visually sift through.
Even worse, sometimes .abi files generate merge conflicts which is quite tedious for a generated artifact.
Propose that instead of including these in the repo, we instead .gitignore them and let devs generate them at compile-time.
Wanted to get thoughts here in case there was a build or deploy usecase I wasn't thinking of.
Beta Was this translation helpful? Give feedback.
All reactions