Skip to content

HANDOVER.md

Latest commit

 

History

History
54 lines (39 loc) · 1.97 KB

HANDOVER.md

File metadata and controls

54 lines (39 loc) · 1.97 KB
Raw

HANDOVER — CodexPlusPlus

Active Work

PR #1247: guard port auto-offset for multi-user RDP

PR: #1247 Branch: fix/guard-port-offset (on lennney fork)

What was done

Replaced hardcoded guard port constants with dynamic resolution:

Before After
LAUNCHER_GUARD_PORT = 57320 launcher_guard_port() — function with offset
MANAGER_GUARD_PORT = 57319 manager_guard_port() — function with offset

Resolution order:

  1. CODEX_PLUS_GUARD_PORT — exact port override
  2. CODEX_PLUS_{LAUNCHER,MANAGER}_GUARD_PORT — per-role override
  3. CODEX_PLUS_GUARD_PORT_OFFSET — explicit offset (e.g. +50)
  4. Windows: USERNAME hash mod 1000 (auto per-user isolation)
  5. Other platforms: 0 (backward compatible)

CI Fix (2026-06-28 23:19)

Problem: All 3 platform builds failed with Rust E0308 type mismatch. Root cause: .and_then(|v| v.parse::<u16>().map_err(|_| ())) — the .or_else() chain maintained Result<_, VarError> type but .map_err(|_| ()) produced Result<_, ()>. Fix (5f9305f): Switched to Option chain: .ok().and_then(|v| v.parse().ok()) Code review: APPROVED ✅ CI: Run 28326773669 in progress

Files changed

File Change
crates/codex-plus-core/src/ports.rs +2 functions, +6 tests, base constants, Option chain fix
apps/codex-plus-launcher/src/main.rs 4 references updated + test assertion
apps/codex-plus-manager/src-tauri/src/lib.rs 5 references updated
apps/codex-plus-manager/src-tauri/tests/windows_subsystem.rs 1 assertion updated

Commits

5f9305f fix(ports): use Option chain for env var parsing to resolve type mismatch
3a4f0aa fix(guard): auto-offset guard port by USERNAME for multi-user RDP

Next steps

  1. Wait for CI (run 28326773669) to complete — verify all 3 platforms green
  2. Wait for upstream maintainer review
  3. If maintainer requests changes, address them