Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice to see you back Bill #18

Open
jones873 opened this issue Oct 7, 2024 · 6 comments
Open

Nice to see you back Bill #18

jones873 opened this issue Oct 7, 2024 · 6 comments

Comments

@jones873
Copy link

jones873 commented Oct 7, 2024

It`s time for you to roll your sleaves up again and weave your magic to take on this very new kid on the block!.... (https://huggingface.co/spaces/haodongli/Lotus_Depth)

@BillFSmith
Copy link
Owner

Nice find! The base results look great. I've had an initial go here:
https://colab.research.google.com/drive/1C9gAdMezh3b0O_yXuQpIunSasoP1BzSz
(I've only really tested it at 1920x1280 resolution, getting errors at different sizes)

From what I can see, the tiled model has a slight improvement in detail, but I don't know if it is as dramatic as with ZoeDepth. Let me know what you think.

@jones873
Copy link
Author

Thank you for doing this for us Bill..

I`ve tried different various sized images but still end up with this result, probably the error is down to me
doing something wrong?..
Untitled

@BillFSmith
Copy link
Owner

Ok, so the code is quite brittle and doesn't like spaces in filenames. I also don't know if it handles different file formats; I've only tested it with .jpg as even .jpeg was unreliable.
That said, something seems up with that link I've posted. I've just run this version, so hopefully it works for you:
https://colab.research.google.com/drive/1TUDfqhK9416avAvI1niXYvzdXubYrGQb?usp=sharing

@jones873
Copy link
Author

Still no Joy Bill, maybe someone else can give it a shot...
Untitled
goldenretriever

@BillFSmith
Copy link
Owner

Oh sorry, could you try with the new link that I posted? Should be titled "Copy of Lotus depth 3 (github).ipynb"

Otherwise I'll try with your image when I get back.

@jones873
Copy link
Author

Thank`s Bill, I was re-testing on you 1st version, because Colab was complaining that I was not using the GPU which you did mention about the ram, V3 did evently do it, but it kept on looping on the last procedure.

I also had to kill the process even though it had already produced the depthmap, anyway excellent results compared to tiled ZoeyDepth thank you very much...
tiled_depth Lotus
Tiled Zoey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants