New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Documentation Around Fangraphs "Month" Parameter #326

Open

camdenk opened this issue Apr 3, 2024 · 1 comment

Assignees

Labels

documentation enhancement

Collaborator

camdenk commented Apr 3, 2024

We need to add checks to automatically set the "month" parameter to be equal to 1000 when querying specific date ranges

# This works
baseballr::fg_batter_leaders(startdate = "2023-03-26", enddate = "2023-04-26", month = "1000")
# This returns the full season
baseballr::fg_batter_leaders(startdate = "2023-03-26", enddate = "2023-04-26")

The text was updated successfully, but these errors were encountered:

camdenk added enhancement documentation labels

camdenk self-assigned this

mikejones763 commented May 8, 2024

Hello! It looks like the month=1000 parameter is a fix for the batter and fielder queries, but not the pitcher queries. Any advice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment