Build issue, on MacOS 15.2 (24C101)

[vmlemon]

Out of curiosity, I tried to build RetroLinker, on Darwin/ARM64, using the following version of CLang:

root@Tysons-MacBook-Air RetroLinker # g++ --version
Apple clang version 16.0.0 (clang-1600.0.26.6)
Target: arm64-apple-darwin24.2.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

Whilst it seems to get pretty far, there's a minor issue, with coff.cc, that prevents things from fully building:

root@Tysons-MacBook-Air RetroLinker # gmake
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/link.o src/link.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/common.o src/common.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/formats.o src/formats.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/buffer.o src/linker/buffer.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/format.o src/linker/format.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/image.o src/linker/image.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/location.o src/linker/location.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/module.o src/linker/module.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/module_collector.o src/linker/module_collector.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/position.o src/linker/position.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/reader.o src/linker/reader.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/reference.o src/linker/reference.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/relocation.o src/linker/relocation.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/resolution.o src/linker/resolution.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/section.o src/linker/section.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/segment.o src/linker/segment.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/segment_manager.o src/linker/segment_manager.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/symbol_definition.o src/linker/symbol_definition.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/symbol_name.o src/linker/symbol_name.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/target.o src/linker/target.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/writer.o src/linker/writer.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/8bitexe.o src/format/8bitexe.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/aif.o src/format/aif.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/aout.o src/format/aout.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/arch.o src/format/arch.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/as86obj.o src/format/as86obj.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/binary.o src/format/binary.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/bwexp.o src/format/bwexp.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/coff.o src/format/coff.cc
src/format/coff.cc:231:38: error: return type of out-of-line definition of 'COFF::COFFFormat::UNIXRelocation::GetEntrySize' differs from that in the declaration
  231 | offset_t COFFFormat::UNIXRelocation::GetEntrySize() const
      | ~~~~~~~~                             ^
src/format/coff.h:335:11: note: previous declaration is here
  335 |                         size_t GetEntrySize() const override;
      |                         ~~~~~~ ^
1 error generated.
gmake: *** [<builtin>: src/format/coff.o] Error 1

[BinaryMelodies]

Thank you for the bug report, the two types definitely need to be aligned.

[BinaryMelodies]

The new commit should fix this issue. Let me know if any further errors pop up during compilation!

[vmlemon]

Thanks!

Looks like it now gets this far...

root@Tysons-MacBook-Air RetroLinker # gmake
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/link.o src/link.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/common.o src/common.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/formats.o src/formats.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/buffer.o src/linker/buffer.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/format.o src/linker/format.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/image.o src/linker/image.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/location.o src/linker/location.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/module.o src/linker/module.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/module_collector.o src/linker/module_collector.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/position.o src/linker/position.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/reader.o src/linker/reader.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/reference.o src/linker/reference.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/relocation.o src/linker/relocation.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/resolution.o src/linker/resolution.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/section.o src/linker/section.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/segment.o src/linker/segment.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/segment_manager.o src/linker/segment_manager.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/symbol_definition.o src/linker/symbol_definition.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/symbol_name.o src/linker/symbol_name.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/target.o src/linker/target.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/writer.o src/linker/writer.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/8bitexe.o src/format/8bitexe.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/aif.o src/format/aif.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/aout.o src/format/aout.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/arch.o src/format/arch.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/as86obj.o src/format/as86obj.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/binary.o src/format/binary.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/bwexp.o src/format/bwexp.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/coff.o src/format/coff.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/cpm68k.o src/format/cpm68k.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/cpm86.o src/format/cpm86.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/cpm8k.o src/format/cpm8k.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/dosexe.o src/format/dosexe.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/elf.o src/format/elf.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/epoc.o src/format/epoc.cc
src/format/epoc.cc:40:11: warning: unused variable 'count' [-Wunused-variable]
   40 |         uint32_t count = rd.ReadUnsigned(4);
      |                  ^~~~~
src/format/epoc.cc:78:11: warning: unused variable 'code_size' [-Wunused-variable]
   78 |         uint32_t code_size = rd.ReadUnsigned(4);
      |                  ^~~~~~~~~
src/format/epoc.cc:89:11: warning: unused variable 'export_dir_count' [-Wunused-variable]
   89 |         uint32_t export_dir_count = rd.ReadUnsigned(4);
      |                  ^~~~~~~~~~~~~~~~
src/format/epoc.cc:138:11: warning: unused variable 'import_table_size' [-Wunused-variable]
  138 |         uint32_t import_table_size = rd.ReadUnsigned(4);
      |                  ^~~~~~~~~~~~~~~~~
4 warnings generated.
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/geos.o src/format/geos.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/format/gsos.o src/format/gsos.cc
src/format/gsos.cc:373:26: error: no matching function for call to 'min'
  373 |                         size_t actual_bytes = std::min(bytes, current_offset + length - offset);
      |                                               ^~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/min.h:35:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('size_t' (aka 'unsigned long') vs. 'offset_t' (aka 'unsigned long long'))
   35 | min(_LIBCPP_LIFETIMEBOUND const _Tp& __a, _LIBCPP_LIFETIMEBOUND const _Tp& __b) {
      | ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/min.h:43:1: note: candidate template ignored: could not match 'initializer_list<_Tp>' against 'size_t' (aka 'unsigned long')
   43 | min(initializer_list<_Tp> __t, _Compare __comp) {
      | ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/min.h:48:86: note: candidate function template not viable: requires single argument '__t', but 2 arguments were provided
   48 | _LIBCPP_NODISCARD_EXT inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX14 _Tp min(initializer_list<_Tp> __t) {
      |                                                                                      ^   ~~~~~~~~~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__algorithm/min.h:29:1: note: candidate function template not viable: requires 3 arguments, but 2 were provided
   29 | min(_LIBCPP_LIFETIMEBOUND const _Tp& __a, _LIBCPP_LIFETIMEBOUND const _Tp& __b, _Compare __comp) {
      | ^                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/format/gsos.cc:437:21: error: implicit instantiation of undefined template 'std::basic_ostringstream<char>'
  437 |         std::ostringstream oss;
      |                            ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__fwd/sstream.h:27:28: note: template is declared here
   27 | class _LIBCPP_TEMPLATE_VIS basic_ostringstream;
      |                            ^
src/format/gsos.cc:1432:23: error: implicit instantiation of undefined template 'std::basic_ostringstream<char>'
 1432 |                         std::ostringstream oss;
      |                                            ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__fwd/sstream.h:27:28: note: template is declared here
   27 | class _LIBCPP_TEMPLATE_VIS basic_ostringstream;
      |                            ^
3 errors generated.
gmake: *** [<builtin>: src/format/gsos.o] Error 1

[BinaryMelodies]

I have looked at it, and most of these errors arise from differring types between 32-bit and 64-bit platforms (not sure why this is happening since you mention building on ARM64). This was easy to fix and I have pushed the changes to the repository. I also added an include for std::ostringstream (I assume it was automatically included by some other header file on my machine, which is why I haven't noticed it).

I haven't checked fully if the 32-bit version of the linker runs properly, but most of the tests seem to generate the same output. There might be some unexpected issues though.

[vmlemon]

Thanks. Just gave it a try, with the latest top-of-tree, and I get this far:

tyson@Tysons-MacBook-Air RetroLinker % make
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/link.o src/link.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/common.o src/common.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/formats.o src/formats.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/buffer.o src/linker/buffer.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/format.o src/linker/format.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/image.o src/linker/image.cc
src/linker/image.cc:40:17: warning: variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension]
   40 |         uint8_t buffer[bytes];
      |                        ^~~~~
src/linker/image.cc:40:17: note: function parameter 'bytes' with unknown value cannot be used in a constant expression
src/linker/image.cc:38:43: note: declared here
   38 | uint64_t ActualImage::ReadUnsigned(size_t bytes, offset_t offset, EndianType endiantype) const
      |                                           ^
src/linker/image.cc:52:17: warning: variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension]
   52 |         uint8_t buffer[bytes];
      |                        ^~~~~
src/linker/image.cc:52:17: note: function parameter 'bytes' with unknown value cannot be used in a constant expression
src/linker/image.cc:50:40: note: declared here
   50 | int64_t ActualImage::ReadSigned(size_t bytes, offset_t offset, EndianType endiantype) const
      |                                        ^
2 warnings generated.
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/location.o src/linker/location.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/module.o src/linker/module.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/module_collector.o src/linker/module_collector.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/options.o src/linker/options.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/position.o src/linker/position.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/reader.o src/linker/reader.cc
src/linker/reader.cc:61:12: warning: variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension]
   61 |         char data[count];
      |                   ^~~~~
src/linker/reader.cc:61:12: note: function parameter 'count' with unknown value cannot be used in a constant expression
src/linker/reader.cc:59:37: note: declared here
   59 | std::string Reader::ReadData(size_t count, bool terminate_at_null)
      |                                     ^
src/linker/reader.cc:88:15: warning: variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension]
   88 |         uint8_t data[bytes];
      |                      ^~~~~
src/linker/reader.cc:88:15: note: function parameter 'bytes' with unknown value cannot be used in a constant expression
src/linker/reader.cc:86:38: note: declared here
   86 | uint64_t Reader::ReadUnsigned(size_t bytes, EndianType endiantype)
      |                                      ^
src/linker/reader.cc:100:15: warning: variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension]
  100 |         uint8_t data[bytes];
      |                      ^~~~~
src/linker/reader.cc:100:15: note: function parameter 'bytes' with unknown value cannot be used in a constant expression
src/linker/reader.cc:98:36: note: declared here
   98 | uint64_t Reader::ReadSigned(size_t bytes, EndianType endiantype)
      |                                    ^
3 warnings generated.
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/reference.o src/linker/reference.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/relocation.o src/linker/relocation.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/resolution.o src/linker/resolution.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/section.o src/linker/section.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/segment.o src/linker/segment.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/segment_manager.o src/linker/segment_manager.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/symbol_definition.o src/linker/symbol_definition.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/symbol_name.o src/linker/symbol_name.cc
c++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -std=c++20 -O2 -g   -c -o src/linker/table_section.o src/linker/table_section.cc
src/linker/table_section.cc:6:16: error: explicit instantiation of 'Linker::TableSection' must occur in namespace 'Linker'
    6 | template class TableSection<Word<uint32_t>>;
      |                ^
src/linker/table_section.h:18:9: note: explicit instantiation refers here
   18 |                 class TableSection : public Section
      |                       ^
src/linker/table_section.cc:7:16: error: explicit instantiation of 'Linker::TableSection' must occur in namespace 'Linker'
    7 | template class TableSection<Word<uint64_t>>;
      |                ^
src/linker/table_section.h:18:9: note: explicit instantiation refers here
   18 |                 class TableSection : public Section
      |                       ^
2 errors generated.
make: *** [src/linker/table_section.o] Error 1

[BinaryMelodies]

Thank you for the valuable feedback! GCC did not report these, so I wasn't aware of these problems. The -Wvla parameter should signal the warning, but I'm not sure how I can make GCC signal the second one. I will try to fix them when I get the time.

Notably, the second one is new code, used for parsing Intel Object Module Formats I misremembered, this code is for generating a Global Offset Table, so it makes sense your compiler didn't get errors on it.

[BinaryMelodies]

The issues have been resolved in the newest commit, please let me know how compilation goes with the update!

Thank you again for your continued testing!

[vmlemon]

Thanks, looks like it now gets this far:

tyson@Tysons-MacBook-Air RetroLinker % gmake
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -Wvla -std=c++20 -O2 -g   -c -o src/link.o src/link.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -Wvla -std=c++20 -O2 -g   -c -o src/common.o src/common.cc
g++ -Wall -Wsuggest-override -Woverloaded-virtual -Wold-style-cast -Wvla -std=c++20 -O2 -g   -c -o src/formats.o src/formats.cc
In file included from src/formats.cc:30:
src/format/omf.h:1933:24: error: non-friend class member 'GenericCommentRecord' cannot have a qualified name
 1933 |                 class CommentRecord::GenericCommentRecord : public CommentRecord
      |                       ~~~~~~~~~~~~~~~^
src/format/omf.h:1948:24: error: non-friend class member 'EmptyCommentRecord' cannot have a qualified name
 1948 |                 class CommentRecord::EmptyCommentRecord : public CommentRecord
      |                       ~~~~~~~~~~~~~~~^
src/format/omf.h:1961:24: error: non-friend class member 'TextCommentRecord' cannot have a qualified name
 1961 |                 class CommentRecord::TextCommentRecord : public CommentRecord
      |                       ~~~~~~~~~~~~~~~^
src/format/omf.h:2050:29: error: non-friend class member 'GenericOMFExtensionRecord' cannot have a qualified name
 2050 |                 class OMFExtensionRecord::GenericOMFExtensionRecord : public OMFExtensionRecord
      |                       ~~~~~~~~~~~~~~~~~~~~^
src/format/omf.h:2065:29: error: non-friend class member 'EmptyOMFExtensionRecord' cannot have a qualified name
 2065 |                 class OMFExtensionRecord::EmptyOMFExtensionRecord : public OMFExtensionRecord
      |                       ~~~~~~~~~~~~~~~~~~~~^
5 errors generated.
gmake: *** [<builtin>: src/formats.o] Error 1

[BinaryMelodies]

Apparently this is an invalid C++ construct I used unknowingly, that GCC accepts and Clang does not. Had I known it was invalid, I might have considered a different design for these classes. A quick fix should be possible though by moving those class definitions outside the OMFFormat class. When I get some time, I will try to fix it.