Skip to content

Commit 76c3a69

Browse files
fix: treat missing labels support as a warning instead of a compatibility error
1 parent 8948b3d commit 76c3a69

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

‎src/validator.test.ts‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -297,17 +297,18 @@ describe('validateViewer', () => {
297297
});
298298

299299
describe('labels support', () => {
300-
it('returns error when data has labels but viewer does not support them', () => {
300+
it('returns warning when data has labels but viewer does not support them', () => {
301301
const viewer = createViewer({ labels: false });
302302
const metadata = createMetadata({
303303
labels: ['nuclei', 'cells']
304304
});
305305

306306
const result = validateViewer(viewer, metadata);
307307

308-
expect(result.compatible).toBe(false);
309-
expect(result.errors).toHaveLength(1);
310-
expect(result.errors[0].capability).toBe('labels');
308+
expect(result.compatible).toBe(true);
309+
expect(result.warnings).toContainEqual(
310+
expect.objectContaining({ capability: 'labels' })
311+
);
311312
});
312313

313314
it('returns compatible when viewer supports labels', () => {

‎src/validator.ts‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,9 @@ export function validateViewer(
113113

114114
// Check for labels
115115
if (metadata.labels && metadata.labels.length > 0 && !viewer.capabilities.labels) {
116-
errors.push({
116+
warnings.push({
117117
capability: 'labels',
118-
message: 'Dataset has labels but viewer does not support them',
119-
required: true,
120-
found: false
118+
message: 'Dataset has labels but viewer may not display them'
121119
});
122120
}
123121

0 commit comments

Comments
 (0)