WhalePrevoutProvider should ignore UTXO that are Immature (<100 confirmations)

[fuxingloh]

We can throw an error when attempting to spend immature UTXO. We can improve and expand on the basic PrevoutProvider while we're at it.

/triage accepted
/area packages

[fuxingloh]

/priority important-soon

[fuxingloh]

/kind feature

[fuxingloh]

/assign @thedoublejay for assignment to @WavesHQ since it directly affects Wallet UX. Not urgent or blocking, do it at your own org pace.

[DieHard073055]

Do I need to update these 2 functions to ignore the UTXO's that are immature?
https://github.com/JellyfishSDK/jellyfish/blob/main/packages/whale-api-wallet/src/prevout.ts#L18-L39
If so how would I get the number of confirmations for a specific UTXO?

[DieHard073055]

@canonbrother gave me this.

const txn = await this.client.rawtx.getRawTransaction(txid, true)

https://github.com/JellyfishSDK/jellyfish/blob/811b25814de3204b21e84e8ccccc82dda75410ae/packages/jellyfish-api-core/src/category/rawtx.ts#L328
rawtx.ts

[DieHard073055]

Also how would I run a test of some sort so I can step through the code to look at what I am working with?

[fuxingloh]

@canonbrother gave me this.

const txn = await this.client.rawtx.getRawTransaction(txid, true)

https://github.com/JellyfishSDK/jellyfish/blob/811b25814de3204b21e84e8ccccc82dda75410ae/packages/jellyfish-api-core/src/category/rawtx.ts#L328

rawtx.ts

Yes, but it's too expensive to call this.

You can get the current block height by using this.client.blockchain.getBlockCount() and probably .filter() and calculate the confirmation manually.

Fortunately,

https://github.com/JellyfishSDK/jellyfish/blob/811b25814de3204b21e84e8ccccc82dda75410ae/packages/whale-api-client/src/api/address.ts#L191

contains block.height so the call won't be expensive.

[DieHard073055]

1. If I were to write a unit test, how should it look like? Is there any other test I can refer to?

2. Should the test be at

packages/whale-api-wallet/__tests__

[fuxingloh]

1. If I were to write a unit test, how should it look like? Is there any other test I can refer to?
2. Should the test be at

packages/whale-api-wallet/__tests__

You can try looking at existing literature on how PRs are created for whale-api related change.

I assumed it's packages/whale-api-wallet/__tests__; you can give it a go — I will review it afterward if it's awkwardly placed.

[DieHard073055]

Looking at the most relevant test (whale.rpc.client.test.ts) in whale-api-client.

I need to instantiate the following.

• WhalePrevoutProvider
  • WhaleWalletAccount
    • WalletEllipticPair
    • Network
• MasterNodeRegTestContainer
• StubService

I am not sure how I can create the WalletEllipticPair type object.

[DieHard073055]

How should I instantiate the wallet which needs to be passed into the WhaleWalletAccountProvider ?
https://github.com/JellyfishSDK/jellyfish/pull/1941/files#diff-feb1151a3ee35e10dfbcbb91329d4a960ee8e7137d07d5a3cedb0fa6268a5c18R90