From f6c50b25bf2a15c0bac4058e17c057f80ef15a24 Mon Sep 17 00:00:00 2001 From: Logic Date: Fri, 5 Jun 2026 19:14:06 +0800 Subject: [PATCH 1/2] test: align constructor port expectations with Bitgesell --- test/client_test.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/test/client_test.js b/test/client_test.js index cc9defb..1e1a85b 100644 --- a/test/client_test.js +++ b/test/client_test.js @@ -58,21 +58,17 @@ describe('Client', () => { }); it('should have default port set to `mainnet`\'s one', () => { - should(new Client().port).equal(8332); + should(new Client().port).equal(8454); }); - it('should set default to port `8332` if network is `mainnet`', () => { - should(new Client({ network: 'mainnet' }).port).equal(8332); + it('should set default to port `8454` if network is `mainnet`', () => { + should(new Client({ network: 'mainnet' }).port).equal(8454); }); it('should set default to port `18332` if network is `testnet`', () => { should(new Client({ network: 'testnet' }).port).equal(18332); }); - it('should set default to port `18332` if network is `regtest`', () => { - should(new Client({ network: 'regtest' }).port).equal(18332); - }); - it('should not have ssl enabled by default', () => { should(new Client().ssl.enabled).equal(false); should(new Client().ssl.strict).equal(false); From de11cea89a15af44f900bf8de8637904ec0e9b1a Mon Sep 17 00:00:00 2001 From: Logic Date: Sun, 7 Jun 2026 15:14:38 +0800 Subject: [PATCH 2/2] test: document unsupported regtest network --- test/client_test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/client_test.js b/test/client_test.js index 1e1a85b..cf823a6 100644 --- a/test/client_test.js +++ b/test/client_test.js @@ -69,6 +69,10 @@ describe('Client', () => { should(new Client({ network: 'testnet' }).port).equal(18332); }); + it('should reject `regtest` because it is not in the Bitgesell network map', () => { + should(() => new Client({ network: 'regtest' })).throw('Invalid network name "regtest"'); + }); + it('should not have ssl enabled by default', () => { should(new Client().ssl.enabled).equal(false); should(new Client().ssl.strict).equal(false);