Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multi-algorithm coin selection #25

Open
theanmolsharma opened this issue Jan 27, 2024 · 3 comments
Open

Implement multi-algorithm coin selection #25

theanmolsharma opened this issue Jan 27, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@theanmolsharma
Copy link
Collaborator

The current CoinSelector class only implements the Lowest Larger coin selection algorithm. The goal is to implement Branch and Bound coin selection and Single Random Draw selection, then use a waste metric to pick the best selection.

Things to implement in CoinSelector class :

  1. selectBranchAndBound()
  2. selectSingleRandomDraw()
  3. getWaste()
  4. update select() in CoinSelector class to call all 3 algorithms, calculate waste for all selections and choose the one with least waste.

References:
Our implementation is very very similar to bcoin's implementation so I suggest reading attemptSelection() and the functions it calls.

@theanmolsharma theanmolsharma added the enhancement New feature or request label Jan 27, 2024
@Ayush170-Future
Copy link
Contributor

Since no one is assigned. I'll start working on this.

@theanmolsharma
Copy link
Collaborator Author

Since no one is assigned. I'll start working on this.

This issue is not a high priority. #24 is a higher priority. I'd appreciate if you work on that instead of this.
#24 is a bit more involved issue, so before you start implementing code, I'd like to see a short description of what changes you'd need to make and how you'd do it. In summary, make a plan first.

@Ayush170-Future
Copy link
Contributor

Since no one is assigned. I'll start working on this.

This issue is not a high priority. #24 is a higher priority. I'd appreciate if you work on that instead of this. #24 is a bit more involved issue, so before you start implementing code, I'd like to see a short description of what changes you'd need to make and how you'd do it. In summary, make a plan first.

Okay, I'll start working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants