Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Expose CSS API #15

Open
JonatanSalas opened this issue Jul 5, 2021 · 0 comments
Open

Feature - Expose CSS API #15

JonatanSalas opened this issue Jul 5, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@JonatanSalas
Copy link
Member

JonatanSalas commented Jul 5, 2021

Motivation

Currently our library is using inline styling to set styles which is really wrong because it limits our users to change the QrReader UI to match their needs.

Proposal

Implement a solution that exposes a .css file, or use a css-in-js library so the component it's encapsulated, also, add the possibility to override styles via a prop called classes like material-ui.

Eg:

<QrReader 
   classes={{ 
     root: 'your-root-class', 
     container: 'your-container-class', 
     video: 'your-video-class 
   }} 
 />
@JonatanSalas JonatanSalas self-assigned this Jul 5, 2021
@JonatanSalas JonatanSalas added the enhancement New feature or request label Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant