Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformed_sweep and composite_colr_glyph sample images are flipped with fonttools 4.38.0 #147

Open
danc86 opened this issue May 2, 2023 · 3 comments

Comments

@danc86
Copy link

danc86 commented May 2, 2023

In requirements.txt there is currently fonttools==4.34.4 pinned, but I'm working on packaging this in nixpkgs and we have fonttools 4.38.0 there. When I run the tests, two sample images are failing because their outputs look different on the cairo and skia backends: transformed_sweep and composite_colr_glyph.

Expected:
glyph_more_samples_transformed_sweep_cairo

Actual:
glyph_more_samples_transformed_sweep_cairo

Expected:
glyph_more_samples_composite_colr_glyph_cairo

Actual:
glyph_more_samples_composite_colr_glyph_cairo

I confirmed that switching back to fonttools 4.34.4 fixes the test failures so it seems to be due to some change in fonttools.

You might know about this already, I guess it's (one of the) issues afflicting PR #146, if so I apologise for the extra noise.

@justvanrossum
Copy link
Collaborator

Thanks for the report! Yes, this is unfortunately a known issue, and no worries about the noise. If you'd see a quick way to fix this: I'm open to a PR.

@anthrotype
Copy link
Contributor

a known issue

I'd be curious to know what exactly changed in fonttools that triggers this issue

@justvanrossum
Copy link
Collaborator

I'd be curious to know what exactly changed in fonttools that triggers this issue

Don't worry, it's an older change: blackrenderer just needs some attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants