Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue using gulp-bless and gulp-rev #41

Open
MannyC opened this issue Feb 18, 2017 · 1 comment
Open

Issue using gulp-bless and gulp-rev #41

MannyC opened this issue Feb 18, 2017 · 1 comment

Comments

@MannyC
Copy link

MannyC commented Feb 18, 2017

I had an issue using this plug-in in conjunction with gulp-rev

Gulp-rev stores some metadata on the vinyl files which it later uses to create a manifest.

Because gulp-bless creates new vinyl files even if it isn't splitting the file, when I run the initial gulp-rev before gulp-bless, none of my css ended up being added to the revision manifest files as the new files don't have the metadata attached.

Currently I am instead running gulp-bless first, then gulp-rev, and then using gulp-rev-replace to update the import(s) in the blessed files (as the second and subsequent files will be renamed by rev).

This works. Another solution would be to copy the metadata into the first of the split files, and into unsplit files. I think that would be my preferred solution, as the rev'd naming convention would make slightly more sense, and it's more likely to just work when introduced into a gulp-rev workflow.

Even if you choose not to address this, then at least this issue can document a workaround.

@adam-lynch
Copy link
Member

Thanks for this. This could hypothetically happen with a lot of other plugins. On one hand I see that we could copy the metadata but on the other hand, someone could argue that that isn't always right. Like what if the metadata property has to be unique or is somehow related to the content of the file. I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants