-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for CT Descriptor wallet to also handle unblinded outputs #38
Comments
Hi @i5hi We are currently evaluating how to handle unblinded outputs. To start, we went for the conservative approach. If we select unblinded utxos, that might not align with the user privacy expectations. Also, selecting unblinded utxos, might make blinding fail, Nevertheless we want to allow users to spend those funds. We'll post updates here. |
Thanks for the update! We currently have a swap flow that uses covenants and we need to send to an unconfidential address to be able to compare amounts during the swap. This is a big blocker for us :S we will need to add some extra logic to at least show that the utxos are there |
I guess it's impossible to find a way in the protocol to use confidential address and pass blinding factors to entities needing to compare amounts like the explorer unblind outputs if the blinding factors are provided |
Hi @i5hi @apotdevin A possible approach that we might pursue is #43 (which still needs some work) Check It's not first class support for handling unblined UTXOs, but it allows spending them. |
We went for the approach in #43 Let us know if the new interface is enough for you @i5hi @apotdevin Still some more fixes and test but we'll add them in the coming days. |
@i5hi @apotdevin wondering what you guys think about this approach. Let us know if this is enough to cover your use case |
For now, we reverted to using a non-covenant flow that allows us to claim funds to a confidential address. While it's not the ideal solution, it allows us to maintain all other aspects of the wallet as they are. |
Haven't had the chance to test it yet. Will look into it over the next week and let you know. From a quick review of the test in lwk_wollet/tests/e2e.rs - test_unblinded_utxo this has been my observation: We mainly have 2 problems:
|
Hi @i5hi
Yes, check the current version of https://github.com/Blockstream/lwk/blob/master/lwk_wollet/tests/e2e.rs , Now we have |
Currently a CT Descriptor Wallet only recognizes blinded outputs. If the user of the wallet shares a confidential address and the sender does not blind the outputs and instead sends to the unblinded address, the wallet does not detect the transaction.
It would be nice if the CT Descriptor Wallet can also recognize and handle unblinded outputs.
The text was updated successfully, but these errors were encountered: