Skip to content
This repository has been archived by the owner on Jan 2, 2025. It is now read-only.

Remove updater from Local build instructions #1263

Closed
drewbitt opened this issue Apr 28, 2024 · 2 comments
Closed

Remove updater from Local build instructions #1263

drewbitt opened this issue Apr 28, 2024 · 2 comments
Labels
feature A new feature

Comments

@drewbitt
Copy link

Problem

When building locally following the instructions in https://github.com/BloopAI/bloop/blob/oss/apps/desktop/README.md, you will get the following error.

+ exit 0
    Bundling [tauri_bundler::bundle::updater_bundle] /Users/drewbitt/Repos/bloop/target/release/bundle/macos/bloop.app.tar.gz (/Users/drewbitt/Repos/bloop/target/release/bundle/macos/bloop.app.tar.gz)
    Finished [tauri_bundler::bundle] 2 bundles at:
        /Users/drewbitt/Repos/bloop/target/release/bundle/macos/bloop.app
        /Users/drewbitt/Repos/bloop/target/release/bundle/dmg/bloop_0.6.4_aarch64.dmg
        /Users/drewbitt/Repos/bloop/target/release/bundle/macos/bloop.app.tar.gz (updater)

       Error [tauri_cli_node] A public key has been found, but no private key. Make sure to set `TAURI_PRIVATE_KEY` environment variable.

Info

This is because of

"pubkey": "dW50cnVzdGVkIGNvbW1lbnQ6IG1pbmlzaWduIHB1YmxpYyBrZXk6IDNGQkQ2RjRBNEM3OURFQ0IKUldUTDNubE1TbSs5UDVIMms5dTU2cVk4cGt4Zzl3bkRXU2UvSzliZktUQTQ5TXFWcmpwb1RvYXMK"

Screenshots

43247

The updater being present will also prompt this, even though this is a local build and we should not be downloading remote updates of prebuilds.

Also secondarily, it is giving me a prompt to update to 0.6.5, but I have the latest branch; this is because you pushed out a 0.6.5 but did not update several locations
63529

Recommendation

Remove the updater code from local build instructions. We can't sign it with your private key and it's not useful.

@drewbitt drewbitt added the feature A new feature label Apr 28, 2024
@anastasiya1155
Copy link
Collaborator

Thank you, @drewbitt, for reporting this issue. I've submitted a pull request to address it. Feel free to test it locally to confirm if it resolves the problem on your end. Otherwise, it should be merged shortly.

@drewbitt
Copy link
Author

That works!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

No branches or pull requests

3 participants