Skip to content
This repository has been archived by the owner. It is now read-only.

[Annotations] Deleting a parameter doesn't clear the selection #80

Open
pafonta opened this issue Jul 19, 2018 · 0 comments
Open

[Annotations] Deleting a parameter doesn't clear the selection #80

pafonta opened this issue Jul 19, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@pafonta
Copy link
Contributor

pafonta commented Jul 19, 2018

Tested with the publication of ID 10.1523/JNEUROSCI.2740-15.2015.

Case 1: Annotation with at least two parameters.

Steps:

  1. Click on a parameter which isn't the latest in the 'Existing parameters' panel.
  2. Click on the button 'Delete'.
  3. Incorrect behaviours:

a) The panels 'Parameter details' and 'Required tag categories' display the data from the parameter which was following in the list the one deleted.

b) If the button 'Save' is clicked, a partial* copy of the parameter which was following in the list the one deleted is added.

* Required tags are not copied, their default values are used.

Stack trace:

None

Case 2: Annotation with only one parameter.

  1. Click on the parameter.
  2. Click on the button 'Delete'.
  3. The following exception is thrown.

Stack trace:

Traceback (most recent call last):
  File "/Users/fonta/repos/neurocurator/neurocurator/modParamWidgets.py", line 356, in deleteParameter
    self.refreshModelingParameters()
  File "/Users/fonta/repos/neurocurator/neurocurator/modParamWidgets.py", line 361, in refreshModelingParameters
    self.loadModelingParameter(selectedRow)
  File "/Users/fonta/repos/neurocurator/neurocurator/modParamWidgets.py", line 392, in loadModelingParameter
    self.paramModStack.currentWidget().loadModelingParameter(row)
  File "/Users/fonta/repos/neurocurator/neurocurator/paramValueWgt.py", line 113, in loadModelingParameter
    self.loadRow(self._parent.currentAnnotation.parameters[row])
IndexError: list index out of range
@pafonta pafonta added the bug label Jul 19, 2018
@pafonta pafonta self-assigned this Jul 19, 2018
@pafonta pafonta added this to the v0.5.0 milestone Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant