Add tests that it works with commonjs as well

Author: MattiasOlla

.mocharc.json

@@ -2,6 +2,7 @@
   "timeout": 10000,
   "reporter": "spec",
   "recursive": true,
+  "ignore": ["test/commonjs/**"],
   "ui": "mocha-cakes-2",
   "require": ["./test/helpers/setup.mjs"],
   "exit": true

eslint.config.js

@@ -1,6 +1,6 @@
 import config from "./index.js";
 
 export default [
-  { ignores: [ "test/data/**/*", "test/helpers/**/*" ] },
+  { ignores: [ "test/data/**/*", "test/helpers/**/*", "test/commonjs/**/*" ] },
   ...config,
 ];

package.json

@@ -5,7 +5,9 @@
   "type": "module",
   "main": "index.js",
   "scripts": {
-    "test": "mocha && eslint ."
+    "test-esm": "mocha",
+    "test-cjs": "cd test/commonjs && mocha",
+    "test": "npm run test-esm && npm run test-cjs && eslint ."
   },
   "repository": {
     "type": "git",

test/commonjs/.mocharc.json

@@ -0,0 +1,9 @@
+{
+  "timeout": 10000,
+  "reporter": "spec",
+  "recursive": true,
+  "spec": "feature/**/*.mjs",
+  "ui": "mocha-cakes-2",
+  "require": ["../helpers/setup.mjs"],
+  "exit": true
+}

test/commonjs/data/js/extends.js

@@ -0,0 +1,18 @@
+"use strict";
+class Foo {
+  constructor(bar) {
+    this.bar = bar;
+  }
+}
+
+class Bar extends Foo {
+  foo(foo) {
+    this.bar = foo;
+  }
+}
+
+function fooer() {
+  return new Bar("test");
+}
+
+fooer();

test/commonjs/data/js/noerrors.js

@@ -0,0 +1,7 @@
+"use strict";
+
+function add(a, b) {
+  return a + b;
+}
+
+add(2, 3);

test/commonjs/feature/lint-js-feature.mjs

@@ -0,0 +1,55 @@
+import { ESLint } from "eslint";
+
+Feature("linting js files (commonjs)", () => {
+  Scenario("js file passing lint rules", () => {
+    let eslint;
+    Given("we have an eslint instance with the base config", () => {
+      eslint = new ESLint({
+        overrideConfigFile: "../../js.js",
+        ignore: false,
+      });
+    });
+
+    let results;
+    When("we lint a folder", async () => {
+      results = await eslint.lintFiles([ "data/js/noerrors.js" ]);
+    });
+
+    Then("we should have linted the correct number of files", () => {
+      expect(results.length).to.eql(1);
+    });
+
+    And("one file should have no messages", () => {
+      expect(results[0].messages.length).to.eql(0, JSON.stringify(results[0].messages));
+    });
+  });
+
+  Scenario("js file does not pass, tries to extend class", () => {
+    let eslint;
+    Given("we have an eslint instance with the base config", () => {
+      eslint = new ESLint({
+        overrideConfigFile: "../../js.js",
+        ignore: false,
+      });
+    });
+
+    let results;
+    When("we lint a file which extends a class", async () => {
+      results = await eslint.lintFiles([ "data/js/extends.js" ]);
+    });
+
+    Then("we should have linted the correct number of files", () => {
+      expect(results.length).to.eql(1);
+    });
+
+    And("one file should have errors", () => {
+      expect(results[0].messages.length).to.be.eql(1, JSON.stringify(results[0].messages));
+    });
+
+    And("one error should be because it extends a class", () => {
+      const error = results[0].messages.find(({ ruleId }) => ruleId === "@bonniernews/typescript-rules/disallow-class-extends");
+      expect(error).to.not.be.undefined;
+      expect(error.message).to.have.string("Extending");
+    });
+  });
+});

test/commonjs/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "commonjs-test",
+  "private": true
+}