-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTG Forge - script to install App from official ftp server #2264
Comments
Hello there 👋 |
multiple issues with this app request
this downloads the latest snapshot at install time but the users install will be outdated once the next snapshot comes output. please move checking for a version to an auto update script and hardcode the version in the install script. the auto update will update the version as necessary.
why this this commented out? also openjdk-17 is not available on all OSs that we support. search pi-apps for temurin and you will find multiple scripts that use their jres and add the apt repo as necessary
pi-apps automatically overrides wget in scripts with aria2c, please remove this |
please avoid installing programs into the users home directory. if it is desired that the user have write permissions into the program folder, then place it in |
Fixed - I added auto-update script that changes version string variable
Sorry. I temporary edited it out for testing. And in the last moment forgot to revert it.
Fixed (needs testing) - I used part of "Minecraft Java Prism Launcher" script to check for OS version and add repo if needed.
I removed this part.
Fixed - I've set game_folder to "$HOME/.local/usr/share/mtg-forge"
Fixed |
no you misunderstood what I meant. only use the root owned /usr/local/share/applications if you place the app in /usr/local/share. your previous locations for the .desktop files were correct with the gamefiles in ~/.local/share also, and this is detrimental to inclusion in pi-apps, https://downloads.cardforge.org/dailysnapshots/ does not include previous days snapshots. so this app will break every day. github releases for this app also only include one version, older versions are deleted. this is not suitable for pi-apps, we need old versions to be cached as we only update apps weekly and users are not expected to always have the latest app versions on their local pi-apps installs. I suggest you create an issue upstream to solve one or both of those issues. for now this is blocked. |
I don't believe this is true, the only available release right now is actually the very first release of Forge on Github. Earlier versions were published on slightly magic forums. But releases are rare, maybe twice a year?
Here's the Issue I opened. In the meantime I made this repo - forge-snapshot-archive, with a simple workflow, that downloads snapshots daily and publishes them as releases. |
Sorry for the delay. It seems Forge won't make previous snapshots available. I updated script to install stable version of forge from official repo releases page. |
sorry for the long time without a response. I saw your issue you made upstream and appreciate the dialog you had there. it looks like upstream is going to do better about publishing stable releases to their github so I would prefer that those be used. while your forge-sanpshot-archive repo could be used, yes its a bit too janky for me to include since neither pi-apps nor the app maintainer controls it. I think the daily snapshots might be too unstable for general users on pi-apps anyway. |
This comment was marked as outdated.
This comment was marked as outdated.
A zipfile was found in the body of an issue comment.
|
@Archargelod upstream has been publishing to their github releases for a few stable releases now. I think those can be used. also, installing java-17 has been greatly simplified with new functions added to pi-apps api pi-apps/apps/Minecraft Java Prism Launcher/install-64 Lines 16 to 29 in 97bcb52
also upstream needs to correct their |
Please see the above comment and update the zip with the requested changes |
@theofficialgman |
What is the name of the app?
Forge
(Optional) Where is the app hosted?
https://downloads.cardforge.org/dailysnapshots/
https://github.com/Card-Forge/forge
About the app
Unofficial MTG Game/Rules Engine
Runs on Java VM, so this game supports both 32 and 64-bit architectures.
Snapshot version, because releases are quickly outdated. Snapshots aren't automatic, they're tested before uploads.
Upload file or Add PR Link
Forge.zip
Confirmations
The text was updated successfully, but these errors were encountered: