Skip to content

Minecraft Java Server: Various improvements#2994

Merged
theofficialgman merged 12 commits into
Botspot:masterfrom
samsoninja:master
Jun 21, 2026
Merged

Minecraft Java Server: Various improvements#2994
theofficialgman merged 12 commits into
Botspot:masterfrom
samsoninja:master

Conversation

@samsoninja

Copy link
Copy Markdown
Contributor

Minecraft 26.1 and newer require Java 25; this adds it as an option. Tested and working on a Raspberry Pi 4, Raspberry Pi OS Trixie.

@LuuOW LuuOW left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical audit: code patterns and architectural layout verified for system reliability.

Folia is a version of Paper with multithreading, which may improve performance
JVM dialog had some spelling errors
@samsoninja samsoninja changed the title Minecraft Java Server: Use Java 25 for Minecraft versions 26.1+ Minecraft Java Server: Various improvements Jun 17, 2026
@samsoninja

Copy link
Copy Markdown
Contributor Author

List of new changes: Use new Paper API so new versions are supported; Add Folia, a Paper fork with multithreading; Fix spelling errors in JVM dialog

@samsoninja

Copy link
Copy Markdown
Contributor Author

New feature: use a custom directory when installing (note that this will generate a file at $HOME/Documents/mcserdir.txt so that uninstalling and updating works as expected)

@samsoninja

Copy link
Copy Markdown
Contributor Author

I've tested this pr and it's now ready to merge, unless someone wants to add another new feature... there may be some edge cases that I didn't test; @Botspot @theofficialgman y'all might want to test it yourselves

Comment thread apps/Minecraft Java Server/install Outdated

@theofficialgman theofficialgman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that all AI assisted development should be indicated should have the linux kernel standard in the commit message like the following example:

Assisted-by: Claude:claude-sonnet-4-6

@theofficialgman theofficialgman marked this pull request as draft June 18, 2026 02:07
I swear this is the last thing
@samsoninja samsoninja marked this pull request as ready for review June 18, 2026 04:02
@samsoninja

Copy link
Copy Markdown
Contributor Author

Ok @theofficialgman I've tested my latest changes and it's working on my RPi 4 with Paper and Folia. It's your script, so I want your feedback, but please be constructive this time :). Still 100% AI free.

Comment thread apps/Minecraft Java Server/install Outdated
Comment on lines +301 to +302
# this is equivalent to using tee "/etc/systemd/system/minecraft-server.service" and then systemctl daemon-reload
sudo systemctl edit --stdin --full --force minecraft-server <<EOF

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either a new/old feature of systemd or AI hallucination.

systemctl: unrecognized option '--stdin'

Please revert back to what this was before. No issue with it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I guess it's sorta new

Comment on lines -295 to -298
# update services
sudo systemctl daemon-reload
sudo systemctl disable minecraft-server

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be re-added. see above

Comment thread apps/Minecraft Java Server/install Outdated

@theofficialgman theofficialgman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comments

I guess Debian Bookworm uses an oldish version of systemd (which makes sense because Bookworm is oldish)
Clarify what I meant by "slightly"
@samsoninja

Copy link
Copy Markdown
Contributor Author

@theofficialgman I made your requested changes... no new changes so it should be good to go

@theofficialgman theofficialgman merged commit e982255 into Botspot:master Jun 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants