Minecraft Java Server: Various improvements#2994
Conversation
LuuOW
left a comment
There was a problem hiding this comment.
Technical audit: code patterns and architectural layout verified for system reliability.
using new api
Folia is a version of Paper with multithreading, which may improve performance JVM dialog had some spelling errors
|
List of new changes: Use new Paper API so new versions are supported; Add Folia, a Paper fork with multithreading; Fix spelling errors in JVM dialog |
|
New feature: use a custom directory when installing (note that this will generate a file at $HOME/Documents/mcserdir.txt so that uninstalling and updating works as expected) |
|
I've tested this pr and it's now ready to merge, unless someone wants to add another new feature... there may be some edge cases that I didn't test; @Botspot @theofficialgman y'all might want to test it yourselves |
theofficialgman
left a comment
There was a problem hiding this comment.
Please note that all AI assisted development should be indicated should have the linux kernel standard in the commit message like the following example:
Assisted-by: Claude:claude-sonnet-4-6
|
Ok @theofficialgman I've tested my latest changes and it's working on my RPi 4 with Paper and Folia. It's your script, so I want your feedback, but please be constructive this time :). Still 100% AI free. |
| # this is equivalent to using tee "/etc/systemd/system/minecraft-server.service" and then systemctl daemon-reload | ||
| sudo systemctl edit --stdin --full --force minecraft-server <<EOF |
There was a problem hiding this comment.
Either a new/old feature of systemd or AI hallucination.
systemctl: unrecognized option '--stdin'
Please revert back to what this was before. No issue with it.
There was a problem hiding this comment.
hmm I guess it's sorta new
| # update services | ||
| sudo systemctl daemon-reload | ||
| sudo systemctl disable minecraft-server | ||
|
|
There was a problem hiding this comment.
needs to be re-added. see above
theofficialgman
left a comment
There was a problem hiding this comment.
see above comments
I guess Debian Bookworm uses an oldish version of systemd (which makes sense because Bookworm is oldish) Clarify what I meant by "slightly"
|
@theofficialgman I made your requested changes... no new changes so it should be good to go |
Minecraft 26.1 and newer require Java 25; this adds it as an option. Tested and working on a Raspberry Pi 4, Raspberry Pi OS Trixie.