From cfac89323c2d1023e87e114fc80c7a509acf8231 Mon Sep 17 00:00:00 2001
From: Vincent Boulanger <vincent@mail.domain.tld>
Date: Thu, 11 Jul 2024 18:17:30 +0200
Subject: [PATCH] OX6-162: Remove iDL frontend bankgrouptype and parameter

---
 .../frontend/tpl/azure/fcpo_payment_ideal.tpl | 21 -------------------
 .../frontend/tpl/flow/fcpo_payment_ideal.tpl  | 21 -------------------
 .../frontend/tpl/wave/fcpo_payment_ideal.tpl  | 21 -------------------
 lib/fcporequest.php                           |  1 -
 4 files changed, 64 deletions(-)

diff --git a/application/views/frontend/tpl/azure/fcpo_payment_ideal.tpl b/application/views/frontend/tpl/azure/fcpo_payment_ideal.tpl
index c649ad1..2be74a0 100644
--- a/application/views/frontend/tpl/azure/fcpo_payment_ideal.tpl
+++ b/application/views/frontend/tpl/azure/fcpo_payment_ideal.tpl
@@ -5,27 +5,6 @@
     </dt>
     <dd class="[{if $oView->getCheckedPaymentId() == $paymentmethod->oxpayments__oxid->value}]activePayment[{/if}]">
 
-        <div class="form-group" id="fcpo_ou_idl">
-            <label class="req control-label col-lg-3">[{oxmultilang ident="FCPO_BANKGROUPTYPE"}]:</label>
-            <div class="col-lg-9">
-                <select name="dynvalue[fcpo_so_bankgrouptype_idl]" class="form-control selectpicker">
-                    <option value="ABN_AMRO_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "ABN_AMRO_BANK"}]selected[{/if}]>ABN Amro Bank</option>
-                    <option value="ASN_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "ASN_BANK"}]selected[{/if}]>ASN Bank</option>
-                    <option value="BUNQ_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "BUNQ_BANK"}]selected[{/if}]>Bunq Bank</option>
-                    <option value="ING_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "ING_BANK"}]selected[{/if}]>ING Bank</option>
-                    <option value="KNAB_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "KNAB_BANK"}]selected[{/if}]>Knab Bank</option>
-                    <option value="N26" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "N26"}]selected[{/if}]>N26</option>
-                    <option value="NATIONALE_NEDERLANDEN" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "NATIONALE_NEDERLANDEN"}]selected[{/if}]>Nationale-Nederlanden</option>
-                    <option value="RABOBANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "RABOBANK"}]selected[{/if}]>Rabobank</option>
-                    <option value="SNS_REGIO_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "SNS_REGIO_BANK"}]selected[{/if}]>SNS Regio Bank</option>
-                    <option value="REVOLUT" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "REVOLUT"}]selected[{/if}]>Revolut</option>
-                    <option value="SNS_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "SNS_BANK"}]selected[{/if}]>SNS Bank</option>
-                    <option value="TRIODOS_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "TRIODOS_BANK"}]selected[{/if}]>Triodos Bank</option>
-                    <option value="VAN_LANSCHOT_BANKIERS" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "VAN_LANSCHOT_BANKIERS"}]selected[{/if}]>Van Lanschot Kempen</option>
-                    <option value="YOURSAFE" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "YOURSAFE"}]selected[{/if}]>Yoursafe</option>
-                </select>
-            </div>
-        </div>
         [{block name="checkout_payment_longdesc"}]
             [{if $paymentmethod->oxpayments__oxlongdesc->value|trim}]
                 <div class="desc">
diff --git a/application/views/frontend/tpl/flow/fcpo_payment_ideal.tpl b/application/views/frontend/tpl/flow/fcpo_payment_ideal.tpl
index 1e4eea5..3662f7e 100644
--- a/application/views/frontend/tpl/flow/fcpo_payment_ideal.tpl
+++ b/application/views/frontend/tpl/flow/fcpo_payment_ideal.tpl
@@ -4,27 +4,6 @@
         <label for="payment_[{$sPaymentID}]"><b>[{oxmultilang ident=$paymentmethod->oxpayments__oxdesc->value}]</b> [{$oView->fcpoGetFormattedPaymentCosts($paymentmethod)}]</label>
     </dt>
     <dd>
-        <div class="form-group" id="fcpo_ou_idl">
-            <label class="req control-label col-lg-3">[{oxmultilang ident="FCPO_BANKGROUPTYPE"}]:</label>
-            <div class="col-lg-9">
-                <select name="dynvalue[fcpo_so_bankgrouptype_idl]" class="form-control selectpicker">
-                    <option value="ABN_AMRO_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "ABN_AMRO_BANK"}]selected[{/if}]>ABN Amro Bank</option>
-                    <option value="ASN_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "ASN_BANK"}]selected[{/if}]>ASN Bank</option>
-                    <option value="BUNQ_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "BUNQ_BANK"}]selected[{/if}]>Bunq Bank</option>
-                    <option value="ING_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "ING_BANK"}]selected[{/if}]>ING Bank</option>
-                    <option value="KNAB_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "KNAB_BANK"}]selected[{/if}]>Knab Bank</option>
-                    <option value="N26" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "N26"}]selected[{/if}]>N26</option>
-                    <option value="NATIONALE_NEDERLANDEN" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "NATIONALE_NEDERLANDEN"}]selected[{/if}]>Nationale-Nederlanden</option>
-                    <option value="RABOBANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "RABOBANK"}]selected[{/if}]>Rabobank</option>
-                    <option value="SNS_REGIO_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "SNS_REGIO_BANK"}]selected[{/if}]>SNS Regio Bank</option>
-                    <option value="REVOLUT" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "REVOLUT"}]selected[{/if}]>Revolut</option>
-                    <option value="SNS_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "SNS_BANK"}]selected[{/if}]>SNS Bank</option>
-                    <option value="TRIODOS_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "TRIODOS_BANK"}]selected[{/if}]>Triodos Bank</option>
-                    <option value="VAN_LANSCHOT_BANKIERS" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "VAN_LANSCHOT_BANKIERS"}]selected[{/if}]>Van Lanschot Kempen</option>
-                    <option value="YOURSAFE" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "YOURSAFE"}]selected[{/if}]>Yoursafe</option>
-                </select>
-            </div>
-        </div>
         <div class="clearfix"></div>
 
         [{block name="checkout_payment_longdesc"}]
diff --git a/application/views/frontend/tpl/wave/fcpo_payment_ideal.tpl b/application/views/frontend/tpl/wave/fcpo_payment_ideal.tpl
index a55b6e6..60f674b 100644
--- a/application/views/frontend/tpl/wave/fcpo_payment_ideal.tpl
+++ b/application/views/frontend/tpl/wave/fcpo_payment_ideal.tpl
@@ -5,27 +5,6 @@
             <label for="payment_[{$sPaymentID}]"><b>[{oxmultilang ident=$paymentmethod->oxpayments__oxdesc->value}]</b> [{$oView->fcpoGetFormattedPaymentCosts($paymentmethod)}]</label>
         </dt>
         <dd class="[{if $oView->getCheckedPaymentId() == $paymentmethod->oxpayments__oxid->value}]activePayment[{else}]payment-option[{/if}]">
-            <div class="form-group" id="fcpo_ou_idl">
-                <label class="req control-label col-lg-3">[{oxmultilang ident="FCPO_BANKGROUPTYPE"}]:</label>
-                <div class="col-lg-9">
-                    <select name="dynvalue[fcpo_so_bankgrouptype_idl]" class="form-control selectpicker">
-                        <option value="ABN_AMRO_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "ABN_AMRO_BANK"}]selected[{/if}]>ABN Amro Bank</option>
-                        <option value="ASN_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "ASN_BANK"}]selected[{/if}]>ASN Bank</option>
-                        <option value="BUNQ_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "BUNQ_BANK"}]selected[{/if}]>Bunq Bank</option>
-                        <option value="ING_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "ING_BANK"}]selected[{/if}]>ING Bank</option>
-                        <option value="KNAB_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "KNAB_BANK"}]selected[{/if}]>Knab Bank</option>
-                        <option value="N26" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "N26"}]selected[{/if}]>N26</option>
-                        <option value="NATIONALE_NEDERLANDEN" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "NATIONALE_NEDERLANDEN"}]selected[{/if}]>Nationale-Nederlanden</option>
-                        <option value="RABOBANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "RABOBANK"}]selected[{/if}]>Rabobank</option>
-                        <option value="SNS_REGIO_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "SNS_REGIO_BANK"}]selected[{/if}]>SNS Regio Bank</option>
-                        <option value="REVOLUT" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "REVOLUT"}]selected[{/if}]>Revolut</option>
-                        <option value="SNS_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "SNS_BANK"}]selected[{/if}]>SNS Bank</option>
-                        <option value="TRIODOS_BANK" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "TRIODOS_BANK"}]selected[{/if}]>Triodos Bank</option>
-                        <option value="VAN_LANSCHOT_BANKIERS" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "VAN_LANSCHOT_BANKIERS"}]selected[{/if}]>Van Lanschot Kempen</option>
-                        <option value="YOURSAFE" [{if $dynvalue.fcpo_so_bankgrouptype_idl == "YOURSAFE"}]selected[{/if}]>Yoursafe</option>
-                    </select>
-                </div>
-            </div>
             <div class="clearfix"></div>
 
             [{block name="checkout_payment_longdesc"}]
diff --git a/lib/fcporequest.php b/lib/fcporequest.php
index 6be3e4c..99a3c55 100755
--- a/lib/fcporequest.php
+++ b/lib/fcporequest.php
@@ -963,7 +963,6 @@ protected function addParametersOnlineIdeal($aDynvalue)
         $this->addParameter('clearingtype', 'sb'); //Payment method
         $this->addParameter('onlinebanktransfertype', 'IDL');
         $this->addParameter('bankcountry', 'NL');
-        $this->addParameter('bankgrouptype', $aDynvalue['fcpo_so_bankgrouptype_idl']);
     }
 
     /**