Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing is_valid call #238

Open
Destiner opened this issue Oct 19, 2018 · 0 comments
Open

Add missing is_valid call #238

Destiner opened this issue Oct 19, 2018 · 0 comments

Comments

@Destiner
Copy link
Contributor

Hi there. When I was working on adding tests, I stumbled upon update_fulfillment method. When I tried to call it from test code, it failed.

I think the reason of failing is that it should call is_valid before saving the object to DB, similar to the fulfill_bounty method just above.

Here's the method: https://github.com/Bounties-Network/BountiesAPI/blob/master/bounties_api/std_bounties/bounty_client.py#L122-L124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Destiner