Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Internal Transactions #7

Open
villanuevawill opened this issue Mar 26, 2018 · 0 comments
Open

Manage Internal Transactions #7

villanuevawill opened this issue Mar 26, 2018 · 0 comments
Labels
Compatibility Other contract integrations Unfortunate :(

Comments

@villanuevawill
Copy link
Collaborator

Currently, we run into a few issues:

  1. Our current architecture does not pass enough information on events. As a result, we have to pull the transaction to find the original inputs: https://github.com/Bounties-Network/BountiesAPI/blob/master/contract_subscriber/eventsRetriever.js#L37-L42 . This approach will not work with wrappers around the std bounties contract. This is because a wrapper contract will create an internal transaction that is not reliable enough to track the original inputs.
  2. Leaderboard and other endpoints track the fulfillment address from msg.sender. This means in the case of an internal transaction, we must grab this value from the data schema. This is a bit tricky and will definitely require us to branch out the code.
@villanuevawill villanuevawill added Compatibility Other contract integrations Unfortunate :( labels Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compatibility Other contract integrations Unfortunate :(
Projects
None yet
Development

No branches or pull requests

1 participant