Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review 1 by Jiahao Zhang #13

Open
jiahaozh opened this issue Nov 13, 2017 · 0 comments
Open

Code review 1 by Jiahao Zhang #13

jiahaozh opened this issue Nov 13, 2017 · 0 comments

Comments

@jiahaozh
Copy link

  • Readme file
    At the beginning page, your readme file is very clearly structured.
  • Website
    The website is attractive as it looks like you guys wanna do something big, not only for a course project👍. However, there is no registration part and when I upload a file, it died. I believe you've just finished yet.
  • Files
    There are so many files in your repositories. Actually some files are not necessary added. And It will be better to rename some files so that it is easier to find. There is a good habit that in most of code files, you have comments. But they are not enough clear to review.
  • Code
    Your code is in a good manner.
  • Thanks.
@jiahaozh jiahaozh changed the title Code review Code review 1 by Jiahao Zhang Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant