Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code review by Hongtao Zhao #16

Open
bruttozz opened this issue Nov 16, 2017 · 0 comments
Open

code review by Hongtao Zhao #16

bruttozz opened this issue Nov 16, 2017 · 0 comments

Comments

@bruttozz
Copy link

At first, I can view all your codes and blocks in a clear way, that's good. And I found you have commented every file when you upload it, which makes it easier for code reviewers to see what is that file or program for. I think our team should learn the document management ability/method from your team.

Although you have made it clear for the light pass, I think there should be more comments in the programs. I haven't learned how to set up webpage before so in your webUI_Networking/client&server_simulation/client_v2.py, I really don't know the function and usage of Fernet.generate_key() in the def encryption(message), could you make a small comment for that? Is this function created by yourself or contained in the python...

Also in the webUI_Networking/client&server_simulation/client_v2.py, I have read your code several times. I realized in your product, the user's information could be cracked easily. Could you use more advanced encryption algorithm? For the sake of not being familiar with cybersecurity, my idea is wrong maybe...

I found you guys have done a lot for your project, from user sign up, log in, data communication, firebase and google api. If you can make these things run well I hope you can add more fancy objects to your project. How to realize your idea in a more efficient way? Could it be applied to business issues? Think more about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant