Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review 2 by Jiahao Zhang #20

Open
jiahaozh opened this issue Dec 5, 2017 · 0 comments
Open

Code Review 2 by Jiahao Zhang #20

jiahaozh opened this issue Dec 5, 2017 · 0 comments

Comments

@jiahaozh
Copy link

jiahaozh commented Dec 5, 2017

Code Error

When I ran Distributivecom/Archive/Aggrigation.py, it shows "SyntaxError: Missing parentheses in call to 'print' "which means you are using python 2. That doesn't matter, but it showed synax error for EXCEPT part.

Register Failure

I noticed that in Distributivecom/WebSite file, there is register.html indeed. But when I entered your website https://distributive-computing.firebaseapp.com/index.html, the "Register Now" part can not work still. I felt confused. Possibly you achieved that part but you should upload your latest webpages screenshot at least

PEP8 Test

I ran some codes on http://pep8online.com/. Some codes have some problems. For example, here is the check results of register.html:result_20171205_063649.txt

File Classification

I think you just put every file you had for your projects on the github, and they are classified into different folders. It can showed your hard work on project obviously. But there still exists three more separate documents .DS_Store, .firebaserc and firebase.json in the main page. Why? .

Folder Description

It's good to see that in Distributivecom/webUI_Networking/ file, you wrote a new readme file owing to itself. But for other files, there is no brief description which may consume much more time to figure out some specific file's meaning.

Redundant Files

Some files are unnecessary since some are too short to show any functionality and some can not even be opened. You should eliminate some useless file and just show the significant files.

@jiahaozh jiahaozh changed the title Code Review by Jiahao Zhang Code Review 2 by Jiahao Zhang Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant