Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review2 by Hongtao Zhao #22

Open
bruttozz opened this issue Dec 7, 2017 · 1 comment
Open

Code Review2 by Hongtao Zhao #22

bruttozz opened this issue Dec 7, 2017 · 1 comment

Comments

@bruttozz
Copy link

bruttozz commented Dec 7, 2017

  1. Firstly, I saw your team have uploaded quite a lot of files after code review1, and you made the classification more clear, it is a good job.

  2. I just noticed that you updated your css file just three hours ago so let me talk from that first. You have a very standard format so that code reviewer can tell each part's function. I think your webpage is delicate enough because you defined the features for footer, index page, buttons... Our group should learn it from you.

  3. And then I viewed your TestSoftware/Resource/dataset/TrainingFiles, I saw there were many samples for training.

  4. When I want to try your service on your web:https://distributive-computing.firebaseapp.com, it asked me to be your user first and then I can upload files, but I didn't find the register button! So you should fix this first. When I want to leave some messages for you on your CONTACT page, there was no feedback after I submitted. I also tried to login without registration, but there was no reminder to tell me whether I was not the user nor the password was wrong.

  5. When I tried another webpage:http://medusapys.site, this one looks pretty than the other one, but when I try to register, it reminded me invalid all the time.

  6. But in general, I believe your team have a clear goal of your project, so please do more test after you publish that, at least make sure your core function works well.

@hariharan-m
Copy link
Collaborator

Hey!
Thanks! We're still working on the organisation and think we could do a better job. Come back soon and hopefully you'll find it in a way better state.

https://distributive-computing.firebaseapp.com was just a test environment. The other site http://medusapys.site is the one that is officially published. We were working on it over the weekend and hence the register function was down. It is up and running now 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants