PHP 8.4 | Fix implicitly nullable parameter #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameter with a `null` default value, which are not explicitly declared as nullable. This commit fixes the one instance found in this codebase. Includes updating the documentation to match. Note: while this is not a `final` class and the change is effectively a change to the method signature, this is not a BC break as (overloaded) constructors are exempt from signature checks. Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
jrfnl
force-pushed
the
feature/php-8.4-fixes
branch
from
530e911 to
d711f8c
Compare
Closed
gmazzap
approved these changes
Aug 28, 2024
|
@gmazzap I see your approval. Any particular reason not to merge this though ? |
|
No, I thought you would merge. But I can do that |
Ah, I'm used to not merging my own PRs (unless I'm the sole maintainer and submitted the PR, but that's not the case here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameter with a
nulldefault value, which are not explicitly declared as nullable.This commit fixes the one instance found in this codebase.
Includes updating the documentation to match.
Note: while this is not a
finalclass and the change is effectively a change to the method signature, this is not a BC break as (overloaded) constructors are exempt from signature checks.Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types