Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eye detection #1

Open
Eurybiadan opened this issue Nov 15, 2017 · 1 comment
Open

Add eye detection #1

Eurybiadan opened this issue Nov 15, 2017 · 1 comment
Assignees
Labels

Comments

@Eurybiadan
Copy link
Contributor

Eye detection is currently meaningless- it checks for a column in the scaling file that isn't there.

Either add a bullet option to the GUI, or parse the filename looking for the eye.

@Eurybiadan Eurybiadan added the bug label Nov 15, 2017
@Eurybiadan Eurybiadan self-assigned this Nov 15, 2017
@dontminchenit
Copy link
Collaborator

dontminchenit commented Dec 2, 2017

I looked into this.

Currently we're searching the .xls file for the identifier 'eye' in the first column and reads the associated 'OD' or 'OS' in the second column. This format is shown in the example examplePosition.xlsx in our demo.

I did find a bug with this though, which might explain any problems you've been having with using the eye information. Apparently we made a change to the parser a while back, such that all the values in the first column is converted to a number first, and then back into a string. This caused the identifier 'eye' to turn into a null, preventing it from being found. I've fixed this bug in my latest update by searching for the string identifiers like this, before converting the IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants