Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tutorial we made to your repo? #25

Open
tpronk opened this issue Apr 4, 2022 · 6 comments
Open

Add a tutorial we made to your repo? #25

tpronk opened this issue Apr 4, 2022 · 6 comments

Comments

@tpronk
Copy link

tpronk commented Apr 4, 2022

Daiichiro Kuroki and I are developing a JavaScript port of QUEST+ named jsQuestPlus. Daiichiro made a tutorial on how to import the output of jsQuestPlus into MATLAB and perform further analyses with your library (mQUESTPlus).

Given that we essentially wrote a little tutorial for mQUESTPlus, it's perhaps nice to move this tutorial to your repo instead of hours. How would you feel about this?

@DavidBrainard
Copy link
Contributor

Yes, I should be able to merge this into the mQUESTPlus repo. Will try to get to it next few weeks.

@kurokida
Copy link

We greatly appreciate your cooperation. mQUESTPlus was very helpful in creating jsQuestPlus.

@DavidBrainard
Copy link
Contributor

Hi,

I took a look at this this morning. I thought the thing to do was add run_qpFit.m to the contributed folder of mQUESTPlus, along with mydata.csv. But when I run the demo, I don't get the same plot as in your html tutorial. The plot I get is attached here. This seems to match the data shown in the html, but not the data shown in your plot. The fit seems reasonable given the data, but the example isn't as nice as the one in the html. I didn't spend a lot of time with this, but perhaps you can clarify.

  1. Does adding these two files to the contributed folder with pointers to your repository and html seem right?
  2. Is there a different data file that will produce the plot in the html (but note that the tabular data in the html seem to match the current file)?

@kurokida
Copy link

Thank you for reviewing. Actually, to make it easier to explain in the tutorial, I limited the number of trials for run_qpFit.m to 10 trials which is too few for fitting. The plot shown in the tutorial was obtained using another 32 trials data.

When I created the tutorial, I thought this explanation was easy to understand, but in light of your point, I have changed the run_qpFit.m to include 32 trials. I have also made slight changes to the tutorial content. Sorry for the confusion.

I agree with the inclusion of both run_qpFit.m and mydata.csv in the contributed folder, but could you wait for @tpronk 's reply?

@DavidBrainard
Copy link
Contributor

@tpronk Your thoughts on the above?

@tpronk
Copy link
Author

tpronk commented Apr 25, 2022

Sounds good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants