-
Notifications
You must be signed in to change notification settings - Fork 19
E2e tests init #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2e tests init #316
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
For me it works as expected
There was a typo in NEXTAUTH vars, fixed! b652ffc So currently we only have an issue with zerion api key, but I think we can skip it for now |
|
Ohh thanks @rin-st!! I just tried locally again and lol it started working for me as well (myabe I re-downloaded the playwright browser). Also another last thing sorry 😅, I was talking with Carlos, and he observed it takes a lot of time for CI to run : Maybe there is a better way to cache this Playwright browser install? Maybe we find something here? Also here in their setup it took only 55 sec: |
|
Good point, added cache step 1c4be91
Action: Also as an option we can install only chromium browser since we disabled tests for others. But I think it's not necessary right now |
technophile-04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like here they said, it not recommended to cache the browser...Shall we try with just Chromium and see how long it takes? (ideally, maybe we should run for diff types of browser) But I think we can go more robust in the future 🙌
If it still takes a very long time for only Chromium, then we could go with the cache. What do you think?
But this is already looking great! Thanks Rinat!!
technophile-04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
love this, thank you all! Let me play with it a bit before merging (maybe next week) |
For me it still works 🤷♂️
Your error is different ( |
|
Ohh it just worked for me! @carletex Can you try this steps once: Uninstall playwright browser: npx playwright@latest uninstall --allInstall playrwright browser: yarn next:playwright-installCache Synpress: yarn next:cache-synpressMv cached id to correct path: mv packages/nextjs/.cache-synpress/532f685e346606c2a803 packages/nextjs/.cache-synpress/08a20e3c7fc77e6ae298Seed the DB: yar db:seedRun the test: yarn next:test |
carletex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 93f5da2.
carletex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merginnnng!
Thanks all





E2e tests for user registration + gh action.
Testing wallet:
0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266To initialize playwright run in your nextjs folder (only first time)
Build wallet cache. It couldn't install metamask extension (11.9.1) with latest versions of playwright/synpress so I used older versions, which use a bit older chromium and MM works fine with it
docs: https://docs.synpress.io/docs/setup-playwright
To run tests locally
yarn next:testfrom root folder or
yarn next:test-uiif you want to see and analyze how it looksThere's one bug though, when running
yarn next:testyou can meet the errorError: Cache for 08a20e3c7fc77e6ae298 does not exist. Create it first!. In that case you need to rename your cache folder name to that "does not exist" cachepackages/nextjs/.cache-synpress/<cache-folder>. In my case it's532f685e346606c2a803to08a20e3c7fc77e6ae298Since the testing user is registered, to make the test work again you need to run remove user from db or run
yarn db:seedfixes: #313