Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relayer URL change #113

Open
UmckaBear opened this issue Jan 30, 2020 · 1 comment
Open

Relayer URL change #113

UmckaBear opened this issue Jan 30, 2020 · 1 comment

Comments

@UmckaBear
Copy link

By default URL field for relayer is empty. You can add URL, but when you try to remove it, page became blank without saving changes. If url contains ":", then it automatically falls under the definition of the correct link, even it contains 2 characters.
Examples:
"w:" - correct for check
"wwww" - doesn't correct

Video example below:
https://drive.google.com/file/d/1J9-FQopXwlAqiAtytx7nDRzLEpxEZ6ec/view?usp=sharing

Also below examples how URL looks like on Relayer Page
URLExamples

It should allow apply empty URL value, or there should be warning, that URL can't be blank, but not page crash.
There should be correct URL check. The correctness of the link should not be tied to just one character ":". It can be http://name, or https://name, or http://IP, or https://IP, or no check for symbols. Warning message should indicate the possible template.

@thanhson1085
Copy link
Contributor

Yep, we should validate the inputs, that i created the issue BuildOnViction/tomorelayer#73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants