Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Uncaught (in promise) Invariant Violation" #128

Closed
CryptoChaser13 opened this issue Feb 4, 2020 · 9 comments
Closed

"Uncaught (in promise) Invariant Violation" #128

CryptoChaser13 opened this issue Feb 4, 2020 · 9 comments

Comments

@CryptoChaser13
Copy link

I tried to apply a logo to my relayer. As i pasted the link of the photo, the page became blank and as i checked on console, It shows "Uncaught (in promise) Invariant Violation" with a red colored font. I also clicked the link it provided and it shown me: Objects are not valid as a React child (found: object with keys {code, message, detail}). Is this normal?

The image link i pasted is tomochain picture.

ERROR LOGO

error two

@thanhson1085
Copy link
Contributor

It is not normal, what link did you use? did you resign your relayer? How to reproduce it?

@CryptoChaser13
Copy link
Author

I did not resign my relayer. But i copied the link address of any image in google (selecing tomochain logo), pasted it to the relayer photo url, submitted it and got the blank screen. Upon clicking Inspect Element, i have got the errors.

My expectation is that, if the photo link isn't allowed, it must pop-up a "Invalid Photo Url" rather than a blank screen which make me reload the relayer and reopen again.

@CryptoChaser13
Copy link
Author

This is a follow-upof the issue i encountered. I tried using a different photo today, which is the link used in the page itself. You can watch the error here which supports my encounter:

https://youtu.be/2MS8jissxGs

@thanhson1085
Copy link
Contributor

thanhson1085 commented Feb 10, 2020

You input wrong image url, the url have to start with 'http' or 'https'.
TomoRelayer do not validate the inputs, we created the issue here. BuildOnViction/tomorelayer#73

@CryptoChaser13
Copy link
Author

Sir. I think i have included that in my expectation here:
#128 (comment)

My expectation is that, if the photo link isn't allowed, it must pop-up a "Invalid Photo Url" rather than a blank screen which make me reload the relayer and reopen again.

That should have cleared the issue which Relayer must do a validation.

@thanhson1085
Copy link
Contributor

If there is validation, you can not submit a wrong link. Then you will not meed the blank page.

@CryptoChaser13
Copy link
Author

And that's what i expect instead of a blank page , at least "Invalid Photo Url" or "Link not Allowed"

@thanhson1085
Copy link
Contributor

I understand. So it is duplicated issue BuildOnViction/tomorelayer#73

@CryptoChaser13
Copy link
Author

Okay. Thanks @thanhson1085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants