-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makeStateKey deprecation causes builder.io not to build in an Angular 18 project #3304
Comments
Thanks for raising this issue. Worth noting that we are actively working on our Gen2 Angular SDK which will be fully compatible with the latest versions of Angular (17+). It will be launching in beta in the near future. |
That's awesome! Can you point me to anything public that I can keep tabs on to prevent opening unnecessary issues in the future? I apologize for wasting anyone's time |
Are you going to add an Angular 18 support for Gen1? |
@jakehockey10 One easy way is to watch out for Angular gen2 SDK releases here: https://github.com/BuilderIO/builder/releases?q=sdk-angular&expanded=true it is currently at 0.0.x, but you will see a clear announcement once it is in Beta (and subsequently in v1). @DzmVasileusky Correct, Gen2 is still in the early stages and cannot currently replace gen1. |
@samijaber Thank you, It would be great to have full Gen1 support until Gen2 stable release. |
Describe the bug
A clear and concise description of what the bug is.
It seems that the
makeStateKey
function is no longer exported from @angular/platform-browser, but instead is importable from @angular/core in the directive builder-content.directive.ts. If you manually change the import from @angular/platform-browser to @angular/core in your local project's node_modules/@builder.io/angular/fesm2020/builder.io-angular.mjs, the project can build again.To Reproduce
Steps to reproduce the behavior:
ng build
The text was updated successfully, but these errors were encountered: