Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeStateKey deprecation causes builder.io not to build in an Angular 18 project #3304

Open
jakehockey10 opened this issue May 25, 2024 · 5 comments

Comments

@jakehockey10
Copy link

Describe the bug
A clear and concise description of what the bug is.

It seems that the makeStateKey function is no longer exported from @angular/platform-browser, but instead is importable from @angular/core in the directive builder-content.directive.ts. If you manually change the import from @angular/platform-browser to @angular/core in your local project's node_modules/@builder.io/angular/fesm2020/builder.io-angular.mjs, the project can build again.

To Reproduce
Steps to reproduce the behavior:

  1. Upgrade project to Angular 18
  2. Attempt to build project with ng build
@jakehockey10 jakehockey10 changed the title makeStateKey deprecation causes builder.io not to builder in an Angular 18 project makeStateKey deprecation causes builder.io not to build in an Angular 18 project May 25, 2024
@samijaber
Copy link
Contributor

Thanks for raising this issue.

Worth noting that we are actively working on our Gen2 Angular SDK which will be fully compatible with the latest versions of Angular (17+). It will be launching in beta in the near future.

@paprikaf paprikaf pinned this issue May 30, 2024
@jakehockey10
Copy link
Author

That's awesome! Can you point me to anything public that I can keep tabs on to prevent opening unnecessary issues in the future? I apologize for wasting anyone's time

@DzmVasileusky
Copy link

@samijaber

Are you going to add an Angular 18 support for Gen1?
We are using it in production and just switching to Gen2 beta doesn't seem something safe since it is still beta.

@samijaber
Copy link
Contributor

@jakehockey10 One easy way is to watch out for Angular gen2 SDK releases here: https://github.com/BuilderIO/builder/releases?q=sdk-angular&expanded=true

it is currently at 0.0.x, but you will see a clear announcement once it is in Beta (and subsequently in v1).

@DzmVasileusky Correct, Gen2 is still in the early stages and cannot currently replace gen1.
We've made a note that some folks still need Gen1 to support angular 18, and will let you know here when there is an update on this.

@DzmVasileusky
Copy link

@samijaber Thank you, It would be great to have full Gen1 support until Gen2 stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants