Skip to content

Migrate chrome extension to MV3 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

patrickkettner
Copy link
Contributor

Fixes #156

@patrickkettner patrickkettner requested a review from a team as a code owner December 16, 2024 19:53
@patrickkettner patrickkettner requested review from harmeet-builder and removed request for a team December 16, 2024 19:53
@kylefowler
Copy link

hey @patrickkettner looks like the builds for the extension fail with these changes as the scripting property doesnt exist on the repo version of chrome. Can you verify that this builds?

@kylefowler
Copy link

Ah, sorry, I didnt see #158

@patrickkettner
Copy link
Contributor Author

rebased ontop of the main branch since #158 was merged.

@kylefowler
Copy link

Having not ever run this project myself locally before, the only issue i see when building and testing within chrome locally is that the assets are not packaged in the dist folder. Not sure if this is a new issue related to the version upgrade PR or an existing one with local development.

image

@patrickkettner
Copy link
Contributor Author

patrickkettner commented Jan 13, 2025 via email

reference the images default property rather than the wrapped object
@patrickkettner
Copy link
Contributor Author

I was wrong, webpack changes how modules were resolved. As you are requireing an image's src, it is resolving to an object whose default value is the image itself. It is now fixed

@kylefowler kylefowler merged commit c74e9df into BuilderIO:master Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome being unsupported soon
2 participants