Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Address #36

Open
gpnunes75 opened this issue Feb 8, 2022 · 4 comments
Open

API Address #36

gpnunes75 opened this issue Feb 8, 2022 · 4 comments

Comments

@gpnunes75
Copy link

I use my pi-hole behind a reverse proxy. It automatically add a prefix /admin at end. So my public address is https://pihole.mydomain this way the api address https://pihole.mydoman/admin/api.php doesn't work.

My suggestion: Add a configuration to add a different api address or create a configuration to bypass reverse proxies.

@gpnunes75
Copy link
Author

I have done those modifications above.

I had to change swiftHole dependence and PiStats. I 'd like to know if I can help and send the modifications to add to those projects.

I put files below

SwiftHole.zip
PiStats-master.zip

@Bunn
Copy link
Owner

Bunn commented Feb 11, 2022

Hey. @gpnunes75 thank you for that I appreciate it, but could you create a PR so it's easier for me to check out the changes?
Feel free to reach me out on twitter (fcbunn) if you have any issues with it :)

@gpnunes75
Copy link
Author

I can do that. Just for clarification. I need to create a PR here and a another on SwiftHole?

@gpnunes75
Copy link
Author

OK, I made a PR to both projects. I Hope I have done right.

I have compiled and tested with no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants