Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Can be grouped with" field has confusing display #112

Open
adamjrice opened this issue Mar 13, 2022 · 4 comments
Open

"Can be grouped with" field has confusing display #112

adamjrice opened this issue Mar 13, 2022 · 4 comments

Comments

@adamjrice
Copy link
Contributor

Clicking on a "Can be grouped with" field seems to show a dropdown menu of all the roles in a given department. However:

  • the menu does not make it clear which roles are already grouped in
  • the menu does not seem to make it possible to ungroup a role
  • the field seems to retain a selected state even after you've tried to deselect it.
  • the menu isn't always wide enough to show all the text it is supposed to contain.

There's enough complexity here that role editing may need to be displayed in a popover window.

@pboyd04
Copy link
Member

pboyd04 commented Mar 26, 2022

It's a multiselect. It should have the currently selected items highlighted like so:
image
If I ungroup a role (just click on it) it becomes unhighlighted (Slinger in this case):
image

Can you show me an example of where it isn't wide enough?

@adamjrice
Copy link
Contributor Author

adamjrice commented Mar 26, 2022

Screen Shot 2022-03-26 at 13 19 54

I wonder if the hyphen is throwing the width calculation off?

@pboyd04
Copy link
Member

pboyd04 commented Mar 26, 2022

Ok think I've got the width thing fixed. Try it now (clear cache)

@adamjrice
Copy link
Contributor Author

That is better. I still think there might be a better way to represent the grouping states--the blue hover state, the gray selected state, and the white unselected state do confuse me a bit, along with the inline tokens, which duplicate some of that information and change their names from "dept_role" to "[x] role" when you select the cell. Maybe checkboxes in the menu? Not sure. I still think that breaking into a detail view for the row might be a better option.

I get why the "dept_role" appearance is important (unless the table showed explicit department subheads), but changing the name is part of the confusion for me

Screen Shot 2022-03-26 at 13 31 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants