Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove path.isfile check #14

Open
paivao opened this issue Apr 21, 2021 · 0 comments
Open

Remove path.isfile check #14

paivao opened this issue Apr 21, 2021 · 0 comments

Comments

@paivao
Copy link

paivao commented Apr 21, 2021 •
edited
Loading

On the line below:

dumpzilla/dumpzilla.py

Line 141 in ec337da

if libnss_path and path.isfile(libnss_path):

you can see that is a check if the libnss_path var is a vaid file, what is always False.

Since CDLL call with handle this correctly, I can assume this is redundant and causes false-negatives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paivao