Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK4: Get the Menu Bar actions working #142

Open
dlbeswick opened this issue Feb 5, 2024 · 2 comments
Open

GTK4: Get the Menu Bar actions working #142

dlbeswick opened this issue Feb 5, 2024 · 2 comments

Comments

@dlbeswick
Copy link
Contributor

#133

Please take a look at this: https://docs.gtk.org/gtk4/actions.html

In previous versions of GTK, logic around menu actions and popups was done via widget signals, and so this logic tended to live inside the widgets that made use of them.

In GTK4, whenever we see popup menu actions or accelerators, they should be implement by creating actions. In many cases it's appropriate to actually move these actions closer to objects implementing the program or at least application logic rather than the UI logic. I would guess that almost all of the actions in the main menu are better moved to BtEditApplication.

@ensonic
Copy link
Member

ensonic commented Feb 5, 2024

I would guess that almost all of the actions in the main menu are better moved to BtEditApplication.

Wouldn't that just become a giant class then?

@dlbeswick
Copy link
Contributor Author

dlbeswick commented Feb 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants