Skip to content

Tests don't remove created files. #66

@juanPabloMiceli

Description

@juanPabloMiceli

Running cargo test doesn't remove the files/folders created during tests as shown below.
image
Of course, these are mostly 0 bytes files but I think it is a little bit messy to leave them there, I can't think of any reason for not deleting them, but maybe I am missing something.

Proposed solution

As far as I could see, all tests are more or less of the form:

fn test_delete_file() {
    create_things_to_be_deleted();
    attempt_to_delete_using_trash();
    assert_deletion();
}

What I propose is adding one more block to the tests where we attempt to delete the created files like so.

fn test_delete_file() {
    create_things_to_be_deleted();
    attempt_to_delete_using_trash();
    delete_from_trash_manually();
    assert_deletion();
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions