Skip to content

Identify all the manual steps perform during the technical review and automatize #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eliselavy opened this issue Jan 9, 2023 · 12 comments
Assignees

Comments

@eliselavy
Copy link
Collaborator

Identify all the manual steps perform during the technical review in order to perform automatically

@eliselavy eliselavy self-assigned this Jan 9, 2023
@eliselavy eliselavy changed the title Identify all the manual steps perform during the technical review Identify all the manual steps perform during the technical review and automatoze Mar 2, 2023
@eliselavy
Copy link
Collaborator Author

@eliselavy eliselavy changed the title Identify all the manual steps perform during the technical review and automatoze Identify all the manual steps perform during the technical review and automatize Mar 7, 2023
@eliselavy
Copy link
Collaborator Author

  • check all urls mentionned and check availability

script need to be integrated here: https://github.com/C2DH/journal-of-digital-history-ipynb-preflight-action/actions/runs/4342893071/jobs/7584262436

eliselavy added a commit to jdh-observer/hXsgcT9BZ5jP that referenced this issue Mar 22, 2023
@eliselavy
Copy link
Collaborator Author

eliselavy commented Apr 18, 2023

@eliselavy
Copy link
Collaborator Author

For the external library, add a check on the output

"outputs": [
    {
     "data": {
      "text/html": [
       "        require.undef(\"plotly\");\n",
       "        **define**('plotly', function(require, exports, module) {\n",

eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Jul 19, 2023
eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Jul 19, 2023
eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Jul 19, 2023
eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Jul 19, 2023
eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Jul 19, 2023
eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Jul 20, 2023
eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Jul 21, 2023
@eliselavy
Copy link
Collaborator Author

For the citation as cite2c and citation manager don't take into account the group , add a check by calling zotero api

eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Jul 25, 2023
@biumiamy
Copy link

For the script result, added a first demo gif to the guideline

eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Aug 17, 2023
@eliselavy
Copy link
Collaborator Author

For the checkoutput.py

Need to look at all type of outputs:

eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Aug 17, 2023
eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Aug 23, 2023
@eliselavy
Copy link
Collaborator Author

eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Sep 20, 2023
@eliselavy
Copy link
Collaborator Author

@eliselavy
Copy link
Collaborator Author

Script more restrictive in github action
Error: Invalid format '- https://licensebuttons.net/l/by/4.0/88x31.png)](https://creativecommons.org/licenses/by/4.0/ returned a 404 status code.'

https://github.com/jdh-observer/m5GhKrrErgfE/actions/runs/6263047507/job/17006567430

eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Sep 26, 2023
eliselavy added a commit to C2DH/journal-of-digital-history-ipynb-preflight-action that referenced this issue Sep 26, 2023
@eliselavy
Copy link
Collaborator Author

@eliselavy
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants