Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thebe integration : plan + use case + testing #211

Closed
eliselavy opened this issue Nov 8, 2023 · 5 comments
Closed

Thebe integration : plan + use case + testing #211

eliselavy opened this issue Nov 8, 2023 · 5 comments
Assignees

Comments

@eliselavy
Copy link
Collaborator

Thebe integration : plan + use case

Kick-off meeting: 9 november
Start of the mission: 13 november

Provide 2 uses case:

@eliselavy eliselavy self-assigned this Nov 8, 2023
@eliselavy
Copy link
Collaborator Author

Another notebook choosen: https://github.com/jdh-observer/jnkqqTTKW8km

Testing:
See: https://github.com/C2DH/journal-of-digital-history/pull/560

See slack discussion https://c2dh.slack.com/archives/C065JHWDCF7

@eliselavy eliselavy changed the title Thebe integration : plan + use case Thebe integration : plan + use case + testing Nov 21, 2023
@eliselavy
Copy link
Collaborator Author

  • R notebook: R kernel not taken into account
Screenshot 2023-11-16 at 10 54 10
  • Notebook with javascript, need to manage the flag:
    /c2dh/journal-of-digital-history/src/components/ArticleV3/Article.js
iv className={`ArticleLayer_cellActive off`} />
              <SimpleArticleCell
                isJavascriptTrusted={false}
                onNumClick={() => ({})}
                memoid={[url, idx].join('-')}
                {...cell}
  • Button 'Reset all' need to bring back the cell input and not only output
  • Problem ressources not found by using Binder: execute-error - [Errno 2] No such file or directory: 'table28-cromwell_northernireland.csv'

@eliselavy
Copy link
Collaborator Author

Jupyter button needs to take binder url from api

@eliselavy
Copy link
Collaborator Author

eliselavy commented Jul 24, 2024

Test made on : https://deploy-preview-637--journalofdigitalhistory.netlify.app/

  • ?v=3&kernelname=IR not yet taken into account
  • problem output javascript not displayed
  • binderurl not taken from the API
Screenshot 2024-07-24 at 17 40 40

Example coming from:
https://deploy-preview-637--journalofdigitalhistory.netlify.app/en/article/L2gBr3BzwH8Z?v=3

https://journalofdigitalhistory.org/api/articles/L2gBr3BzwH8Z/
"binder_url": "https://mybinder.org/v2/gh/jdh-observer/jdh001-L2gBr3BzwH8Z/main?filepath=skim-article.ipynb"

@eliselavy
Copy link
Collaborator Author

Test made on : https://deploy-preview-637--journalofdigitalhistory.netlify.app/

  • ?v=3&kernelname=IR not yet taken into account
  • problem output javascript not displayed
  • binderurl not taken from the API
Screenshot 2024-07-24 at 17 40 40 Example coming from: https://deploy-preview-637--journalofdigitalhistory.netlify.app/en/article/L2gBr3BzwH8Z?v=3

https://journalofdigitalhistory.org/api/articles/L2gBr3BzwH8Z/ "binder_url": "https://mybinder.org/v2/gh/jdh-observer/jdh001-L2gBr3BzwH8Z/main?filepath=skim-article.ipynb"

All points fixed
Testing made
Need to see the problem with the graph of Edge Cases: The Making of Network Navigator and Critical Approaches to DH Tools article

but in this article generated perfectly: https://journalofdigitalhistory.netlify.app/en/article/VeaK58WBs82C?v=3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant