Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workflow technical review #214

Open
jdh-observer opened this issue Dec 5, 2023 · 2 comments
Open

Improve workflow technical review #214

jdh-observer opened this issue Dec 5, 2023 · 2 comments
Assignees

Comments

@jdh-observer
Copy link

jdh-observer commented Dec 5, 2023

  • fix the problem of permission at the creation of the GitHub repository by using template
Workflow permissions
  • fix problem of wrong tagging detected : 'figure-late-b-moves-*' but not wrong tag
  • include nbconvert in the action
  • remove the raw url as mandatory field for technical / peer review
@eliselavy eliselavy self-assigned this Dec 5, 2023
@eliselavy
Copy link
Collaborator

Validation of the ressources of the author:
wrong file name for nbconvert
C2DH/jdh-notebook#135 (comment)

@eliselavy
Copy link
Collaborator

eliselavy commented Jan 10, 2024

fields : "notebook_url", "notebook_path", "binder_url", "notebook_ipython_url" will now be populated manually, still in branch https://github.com/C2DH/journal-of-digital-history-backend/commits/feature-214
for the workflow permission : by creating a repository from a template , the workflow permission are changed and not keep as define
solution will be to transform the GitHub template in a repo to fork

eliselavy added a commit that referenced this issue Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants