Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: There may be a breaking JQuery change affecting collapse/expansion of user-interface components #198

Open
ross-spencer opened this issue May 22, 2020 · 2 comments
Labels

Comments

@ross-spencer
Copy link

ross-spencer commented May 22, 2020

SCOPE uses a control that can expand/collapse as requested. It appears in the content menu, but also for the expansion of preservation metadata.

image

Trying to expand the component will result in a JQuery error that can be seen in the developer tools.

Googling the issue returned that there may be a breaking change in JQuery 3.5 which is affecting this: https://stackoverflow.com/a/61177704

This seemed a good enough hypothesis to begin and so we can confirm usage of 3.5 here.

Changing this line to 3.4.1 and then (for Docker):

  • sudo docker-compose exec scope npm install
  • sudo docker-compose exec scope npm rebuild

And then refreshing my browser I get a successful outcome:

image

So that might be one way forward, i.e. a decent workaround. The solution may lie elsewhere though.

Thanks Radda for the advice on building NPM and helping demo this a bit quicker .

@jraddaoui
Copy link
Collaborator

Thanks for reporting and investigating @ross-spencer!

It looks like jQuery fixed the issue 5 days after we upgraded in a 3.5.1 release. The 3.4.1 version has known vulnerabilities, so luckily they fixed the issue quick.

@ross-spencer
Copy link
Author

Awesome, thanks @jraddaoui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants