Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KT] (AICCRA) Develop Feedback Functionality #2429

Open
8 tasks done
kenjitm opened this issue Apr 26, 2022 · 8 comments
Open
8 tasks done

[KT] (AICCRA) Develop Feedback Functionality #2429

kenjitm opened this issue Apr 26, 2022 · 8 comments
Assignees
Labels
AICCRA Developments related to the MARLO version for AICCRA Priority - High Type - Enhancement

Comments

@kenjitm
Copy link
Contributor

kenjitm commented Apr 26, 2022

Develop the feedback functionality in AICCRA according to the following template: https://docs.google.com/presentation/d/1AEW7EoDeNzOxVsoMZLDZqZoE9oHfWnA37_kXI0tuCx4/edit#slide=id.ge82d74f50f_0_5

  • It must be possible to enable or disable the functionality of commenting on a specific field

  • It must possible to comment on a certain field by the Module Leaders and Managers Module
    image.png

  • It must be possible to respond to the comments, approve or disapprove them, by the Leaders and Coordinators of the cluster
    image.png

  • A section should be created where the information of the comments made in the fields at the cluster level can be seen in a consolidated manner through the embedding of a BI report
    image.png

  • It must be indicated next to the name of each section of the cluster, the number of pending comments to be answered.
    image.png

  • At the administrator level, a section must be created in which a BI graph is embedded showing the comments consolidator for all clusters
    image.png

  • Create specificity for safeguard section

  • Allow delete comments

@kenjitm kenjitm added AICCRA Developments related to the MARLO version for AICCRA Priority - High Type - Enhancement labels Apr 26, 2022
@kenjitm kenjitm changed the title [KT] (AICCRA) Develop Feedback functionality [KT] (AICCRA) Develop Feedback Functionality Apr 26, 2022
@kenjitm
Copy link
Contributor Author

kenjitm commented Apr 26, 2022

It's possible to enable comments pop-up functionality for specific fields:
image.png

And save comments for the selected field:
image.png

@kenjitm
Copy link
Contributor Author

kenjitm commented Apr 28, 2022

image.png

  • Feedback functionality is filtered by roles, cluster leaders and coordinators will be able to approve, reject or respond to comments.
  • The comment left by a user is displayed along with its information

@MargaritaRamirez
Copy link

@valviveros
In meeting with Hector this morning, he requests the following change in the feedback status banner
image.png

blue: No comments provided
green: All comments tackled

@valviveros
Copy link
Contributor

The requested change has been made.
image

@MargaritaRamirez
Copy link

image.png
image.png
image.png
image.png

In addition we will remove the icon at the right and colored the comments boxes

@yecksin
Copy link
Contributor

yecksin commented May 31, 2022

image.png

About the May 26th meeting =>

It was discussed that there is no problem with the development time on the front end, since the MARLO logic is complex, so you must have a good level of abstraction and recursion. However, it can be improved by receiving adequate information in the services, e.g. that the "list" is iterable by default, since with many objects a more complex and time-consuming mapping must be done.

The only advice is to keep in mind good practices in "Clean Code" to be able to retake code when time goes by and reduce the technical debt in the future.

If "MARLO / AICCRA" is going to have more development time in the future with new features, it is better to resume the use of Vue.js as Sebastian did in the past. The advantage is also that you can hire people who work with Vue.js because we can reduce the use of MARCOS with FreeMarker and have a more dynamic code.

@MargaritaRamirez
Copy link

Message sent on June 8th, 2022

image.png

image.png

@MargaritaRamirez
Copy link

Replay from Laura (our comments in blue)

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AICCRA Developments related to the MARLO version for AICCRA Priority - High Type - Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants