Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dockerfile to containerize billing script #21

Closed
QuanMPhm opened this issue Apr 18, 2024 · 6 comments · Fixed by #31
Closed

Create Dockerfile to containerize billing script #21

QuanMPhm opened this issue Apr 18, 2024 · 6 comments · Fixed by #31
Assignees

Comments

@QuanMPhm
Copy link
Contributor

Splitting up #15, and dependent on #20, as the next step before creating a fully automated cronjob to process invoices, we want to create a Docker container containing the bare dependencies needed to run the cloning and billing script.

@QuanMPhm QuanMPhm self-assigned this Apr 18, 2024
@QuanMPhm
Copy link
Contributor Author

@knikolla @naved001 As a solution I will create a Docker container with a shell script which does the following:

  • Clone the non-billable repo
  • Fetches the invoices for the previous month from S3 storage
  • Passes all relevant files to process_report.py

@knikolla
Copy link
Contributor

@knikolla @naved001 As a solution I will create a Docker container with a shell script which does the following:

  • Clone the non-billable repo
  • Fetches the invoices for the previous month from S3 storage
  • Passes all relevant files to process_report.py

@QuanMPhm And 4th step, uploads the generated invoices in the appropriately named way.

@QuanMPhm
Copy link
Contributor Author

My questions/things I need so far are:

  • I need access to a list of Old PIs. Where is that currently stored? @naved001 suggested that it should be placed in the nonbillable repo alongside other files that would impact billing.
  • @joachimweyl @knikolla Since we want this Docker container to upload the processed invoices back to S3, what should be the naming convention for all the HU-only, HU & BU only, Lenovo-only, and the PI-specific invoices?

@joachimweyl
Copy link
Contributor

joachimweyl commented Apr 22, 2024

@QuanMPhm here is a list of the PIs.

The naming convention for the files should be

HU&BU - NERC-<YYYY>-<MM>-Total-Invoice.csv
Lenovo-only - Lenovo-<YYYY>-<MM>.csv
PI specific - <University>_<PI>_<YYYY>-<MM>.csv
HU-only - We no longer need this, HU pulls from HU&BU file

@QuanMPhm
Copy link
Contributor Author

QuanMPhm commented Apr 24, 2024

@joachimweyl If it's not a big problem, I'll have the file names be as follows:

HU&BU - NERC Total Invoice <YYYY>-<MM>.csv
BU Internal - NERC BU <YYYY>-<MM>.csv
Lenovo-only - Lenovo <YYYY>-<MM>.csv
PI specific - PI Invoices/<University>_<PI>_<YYYY>-<MM>.csv

It would just simplify the code if the invoice month (YYYY-MM) is consistently placed at the end of the filename.

@joachimweyl
Copy link
Contributor

Please make sure HU&BU is labeled NERC-<YYYY>-<MM>-Total-Invoice.csv as that is the file name MGHPCC requested. The others look fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants